Merge lp:~openerp-dev/openobject-addons/6.0-opw-382052-han into lp:openobject-addons/6.0

[Hardik Ansodariya (OpenERP)]

Hello,

Fixed the issue of when we have a product in type 'Service' that generates a task
when confirming a Sales Order, the name of the partner is not kept from the
order

Thanks
Hardik

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Xavier ALT (dex-phx)]

Hello,

Better than searching for sale order with "name" like procurement "origin", we could use "procurement_id" on sale.order.line. Looking at sale/sale.py, line 731, the _exact_ "procurement_id" is written on sale.order.line just after it's creation.

And also, make sure if we do not found any sale.order.line, we should not browse it + task 'partner_id' field should stay as False.

Cheers,
Xavier

review: Needs Fixing

[Hardik Ansodariya (OpenERP) (han-tinyerp)]

Hello Xavier,

I have fixed the issue as per your suggestion.

kindly review it.

Thanks
Hardik

review: Needs Resubmitting

[Naresh(OpenERP) (nch-openerp)]

Hello Hardik,

what if there is no sale order line ?

you should check for Sale order line existence if no then the partner_id should be False

something like:
If line_id:
then browse for line_id and get the partner id.

Thanks,
Naresh

review: Needs Fixing

[Hardik Ansodariya (OpenERP) (han-tinyerp)]

Hello,

Add validation if line_id then get partner_id otherwise partner_id False.

Thanks

review: Needs Resubmitting

[lp:~openerp-dev/openobject-addons/6.0-opw-382052-han]

5041. By Hardik Ansodariya (OpenERP) on 2012-03-26

[Fixed] project_mrp: Add validation if line_id then get partner_id else False (Maintanace Case: 382052)

[Naresh(OpenERP) (nch-openerp)]

review: Approve

Unmerged revisions

5041. By Hardik Ansodariya (OpenERP) on 2012-03-26

[Fixed] project_mrp: Add validation if line_id then get partner_id else False (Maintanace Case: 382052)

5040. By Hardik Ansodariya (OpenERP) on 2012-03-26

[Fixed] project_mrp: Add validation if line_id then get partner_id else False (Maintanace Case: 382052)

5039. By Hardik Ansodariya (OpenERP) on 2012-03-20

[FIX] project_mrp: project_mrp: when confirming a Sales Order, the name of the partner is not kept by using procurement_id (Maintenance Case : 382052)

5038. By Hardik Ansodariya (OpenERP) on 2012-02-07

[FIX] project_mrp: when confirming a Sales Order, the name of the partner is not kept from the :(Maintenance Case : 382052)

=== modified file 'project_mrp/project_procurement.py'
--- project_mrp/project_procurement.py	2011-05-07 11:24:17 +0000
+++ project_mrp/project_procurement.py	2012-03-26 12:59:16 +0000
@@ -35,7 +35,12 @@
     def action_produce_assign_service(self, cr, uid, ids, context=None):
         task_obj = self.pool.get('project.task')
         uom_obj = self.pool.get('product.uom')
+        sale_order_line_obj = self.pool.get('sale.order.line')
+        partner_id = False
         for procurement in self.browse(cr, uid, ids, context=context):
+            line_id = sale_order_line_obj.search(cr, uid, [('procurement_id', '=', procurement.id)],context=context)
+            if line_id:
+                partner_id = sale_order_line_obj.browse(cr, uid, line_id, context=context)[0].order_id.partner_id.id
             self.write(cr, uid, [procurement.id], {'state': 'running'})
             planned_hours = procurement.product_qty
             proj_uom_id = procurement.company_id.project_time_mode_id.id
@@ -55,6 +60,7 @@
                 'date_deadline': procurement.date_planned,
                 'project_id': procurement.product_id.project_id and procurement.product_id.project_id.id or False,
                 'company_id': procurement.company_id.id,
+                'partner_id': partner_id
             },context=context)
             self.write(cr, uid, [procurement.id],{'task_id':task_id}) 
         return task_id