Merge lp:~openerp-dev/openobject-addons/6.0-opw-381849-ado into lp:openobject-addons/6.0

[Amit Dodiya (OpenERP)]

Hello,

[FIX] In warning module onchange_partner_id has some re assignation of values"

Thanks,
Amit Dodiya

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Jean-Christophe VASSORT (jc-vassort)]

In parent class, on account/invoice.py file, onchange_partner_id method signature is like this:

def onchange_partner_id(self, cr, uid, ids, type, partner_id,\
            date_invoice=False, payment_term=False, partner_bank_id=False, company_id=False):

I think it is better to not forget the company_id parameter in the super() function, and wrote:

result = super(account_invoice, self).onchange_partner_id(cr, uid, ids, type, partner_id,
            date_invoice=date_invoice, payment_term=payment_term, partner_bank_id=partner_bank_id, company_id=company_id)

What do you think about this ?

review: Needs Fixing

[lp:~openerp-dev/openobject-addons/6.0-opw-381849-ado]

5106. By Xavier ALT on 2012-03-06

[MERGE] OPW 16328 - do not request write off when generating fy opening entries

5107. By Xavier ALT on 2012-03-06

[MERGE] OPW 382063 - account fiscal year closing: fix default date in opening entries

5108. By Xavier ALT on 2012-03-06

[MERGE] OPW 279130 - translate errors raised inside product_id_change (sale/purchase) dep. on user lang., not partner lang.

5109. By Xavier ALT on 2012-03-06

[MERGE] OPW 51075 - account.move.line: reconcile_partial() error msg when lines are already reconciled

5110. By Xavier ALT on 2012-03-06

[MERGE] OPW 51189 - on invoice 'refund', keep original salesman and fiscal position

5111. By Xavier ALT on 2012-03-06

[MERGE] OPW 18001: do not lock-out user when payment.order is 'done', allow it to cancel it

  - When 'Payment Order' is in 'done' state, the workflow is frozen and the
    user is unable to cancel it (required in case bank refuse the payment).
    This allow to cancel the payment order except when some lines are already
    imported in a bank statement (i.e payment done bank-side: modification
    forbidden).

5112. By Xavier ALT on 2012-03-06

[MERGE] OPW 18001: l10n_ch: create_date wizard was not saving file inside wizard

5113. By Xavier ALT on 2012-03-06

[MERGE] OPW 381524 - on picking invoicing, do not invoice scrapped products

5114. By Launchpad Translations on behalf of openerp on 2012-03-07

Launchpad automatic translations update.

5115. By Launchpad Translations on behalf of openerp on 2012-03-08

Launchpad automatic translations update.

5116. By nel on 2012-03-08

[MERGE]

5117. By nel on 2012-03-08

[MERGE]

5118. By nel on 2012-03-08

[MERGE]

5119. By nel on 2012-03-08

[MERGE]

5120. By nel on 2012-03-08

[MERGE]

5121. By Launchpad Translations on behalf of openerp on 2012-03-09

Launchpad automatic translations update.

5122. By Launchpad Translations on behalf of openerp on 2012-03-10

Launchpad automatic translations update.

5123. By Jean-Christophe VASSORT on 2012-03-12

[MERGE] OPW 51090 Freight tax not calculating automatically on invoice

5124. By Amit Dodiya (OpenERP) on 2012-03-12

[FIX] In warning module onchange_partner_id has some re assignation of values

[Amit Dodiya (OpenERP) (ado-openerp)]

Hello,

The code is changed as per your suggestion.

Regards,
Amit

review: Needs Resubmitting

Unmerged revisions

5124. By Amit Dodiya (OpenERP) on 2012-03-12

[FIX] In warning module onchange_partner_id has some re assignation of values

=== modified file 'warning/warning.py'
--- warning/warning.py	2011-01-14 00:11:01 +0000
+++ warning/warning.py	2012-03-12 11:00:38 +0000
@@ -138,7 +138,7 @@
                 'message': message
                 }
         result =  super(account_invoice, self).onchange_partner_id(cr, uid, ids, type, partner_id,
-            date_invoice=False, payment_term=False, partner_bank_id=False)
+            date_invoice, payment_term, partner_bank_id, company_id)
 
         if result.get('warning',False):
             warning['title'] = title and title +' & '+ result['warning']['title'] or result['warning']['title']