Merge lp:~openerp-dev/openobject-addons/6.0-opw-18226-skh into lp:openobject-addons/6.0

Proposed by Somesh Khare
Status: Merged
Approved by: Naresh(OpenERP)
Approved revision: 4904
Merge reported by: nel
Merged at revision: not available
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-opw-18226-skh
Merge into: lp:openobject-addons/6.0
Diff against target: 62 lines (+33/-2)
2 files modified
account/account_invoice_view.xml (+2/-2)
account_cancel/account_cancel_view.xml (+31/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-18226-skh
Reviewer Review Type Date Requested Status
Priyesh (OpenERP) (community) Approve
Leonardo Pistone (community) Approve
Lorenzo Battistini (community) Approve
Olivier Laurent (Open ERP) Pending
Vo Minh Thu Pending
Review via email: mp+80868@code.launchpad.net

Description of the change

Hello VMT,

back ported from the trunk revision: 5390

BUG: 807543 "re-open invoice assigned to useability/no one".

Kindly review this and notify if it requires any other changes.

Thanks,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

That branch works for our customers. What about merging it into 6.0?

review: Approve
Revision history for this message
Priyesh (OpenERP) (pso-openerp) wrote :

Hello Somesh,

It works fine as per expectations.

Thanks for the fix,
Priyesh

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_invoice_view.xml'
2--- account/account_invoice_view.xml 2011-01-20 14:02:14 +0000
3+++ account/account_invoice_view.xml 2011-11-01 06:33:24 +0000
4@@ -211,7 +211,7 @@
5 <field name="state"/>
6 <field name="residual"/>
7 <group col="6" colspan="4">
8- <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel"/>
9+ <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel" groups="base.group_no_one"/>
10 <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object" icon="terp-stock_effects-object-colorize"/>
11 <button name="%(action_account_invoice_refund)d" type='action' string='Refund' states='open,paid' icon="gtk-execute"/>
12 <button name="%(action_account_state_open)d" type='action' string='Re-Open' states='paid' icon="gtk-convert" groups="base.group_no_one"/>
13@@ -305,7 +305,7 @@
14 <field name="state"/>
15 <field name="residual"/>
16 <group col="8" colspan="4" groups="base.group_user">
17- <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel"/>
18+ <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel" groups="base.group_no_one"/>
19 <button name="action_cancel_draft" states="cancel" string="Reset to Draft" type="object" icon="terp-stock_effects-object-colorize"/>
20
21 <button name="%(action_account_invoice_refund)d" type='action' string='Refund' states='open,paid' icon="gtk-execute"/>
22
23=== modified file 'account_cancel/account_cancel_view.xml'
24--- account_cancel/account_cancel_view.xml 2011-01-14 00:11:01 +0000
25+++ account_cancel/account_cancel_view.xml 2011-11-01 06:33:24 +0000
26@@ -12,5 +12,36 @@
27 </field>
28 </field>
29 </record>
30+ <record id="invoice_form_cancel_inherit" model="ir.ui.view">
31+ <field name="name">invoice.form.cancel.inherit</field>
32+ <field name="model">account.invoice</field>
33+ <field name="type">form</field>
34+ <field name="inherit_id" ref="account.invoice_form"/>
35+ <field name="arch" type="xml">
36+ <xpath expr="/form/notebook/page/group/group/button[@name='%(account.action_account_state_open)d']" position="replace">
37+ <button name='%(account.action_account_state_open)d' type='action' string='Re-Open' states='paid' icon="gtk-convert" groups="account.group_account_invoice"/>
38+ </xpath>
39+ <xpath expr="/form/notebook/page/group/group/button[@name='invoice_cancel']" position="replace">
40+ <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel" groups="account.group_account_invoice"/>
41+ </xpath>
42+ </field>
43+ </record>
44+
45+ <record id="invoice_supplier_cancel_form_inherit" model="ir.ui.view">
46+ <field name="name">invoice.supplier.cancel.form.inherit</field>
47+ <field name="model">account.invoice</field>
48+ <field name="type">form</field>
49+ <field name="inherit_id" ref="account.invoice_supplier_form"/>
50+ <field name="arch" type="xml">
51+ <xpath expr="/form/notebook/page/group/group/button[@name='%(account.action_account_state_open)d']" position="replace">
52+ <button name='%(account.action_account_state_open)d' type='action' string='Re-Open' states='paid' icon="gtk-convert" groups="account.group_account_invoice"/>
53+ </xpath>
54+ <xpath expr="/form/notebook/page/group/group/button[@name='invoice_cancel']" position="replace">
55+ <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="gtk-cancel" groups="account.group_account_invoice"/>
56+ </xpath>
57+ </field>
58+ </record>
59+
60+
61 </data>
62 </openerp>