Merge lp:~openerp-dev/openobject-addons/6.0-opw-16423-ira into lp:openobject-addons/6.0

[Ila Rana(Open ERP)]

Hello,

crm_profiling: Improvement in Unique key contraints.

Regards,
Ila Rana.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Ila,

I disagree with the treatment. You opted to remove(-) the records rather than stopping them to be added(+).

On a positive note, code should like this:
if x[0] not in temp:
    temp.append(x[0])

Hope this helps.

Thanks.

review: Needs Fixing

Unmerged revisions

4736. By Ila Rana(Open ERP) on 2011-07-28

[FIX]:crm_profiling:improvement in unique key constraint(case:16423)

=== modified file 'crm_profiling/crm_profiling.py'
--- crm_profiling/crm_profiling.py	2011-01-14 00:11:01 +0000
+++ crm_profiling/crm_profiling.py	2011-07-28 13:51:35 +0000
@@ -226,8 +226,9 @@
         query = "select answer from partner_question_rel where partner=%s"
         cr.execute(query, (data['id'],))
         for x in cr.fetchall():
+            if x[0] in temp:
+                temp.remove(x[0])
             temp.append(x[0])
-
         self.write(cr, uid, [data['id']], {'answers_ids':[[6, 0, temp]]}, context=context)
         return {}
 
@@ -310,9 +311,6 @@
                 for pid in to_remove_list:
                     partners.remove(pid)
 
-            for partner_id in partners:
-                cr.execute('insert into res_partner_category_rel (category_id,partner_id) values (%s,%s)', (categ['categ_id'][0],partner_id))
-
             self.write(cr, uid, [id], {'state':'not running', 'partner_id':0})
         return True