Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/6.0-594332-opw-ado into lp:openobject-addons/6.0

  1. 6.0-594332-opw-ado
  2. Merge into 6.0
Proposed by Amit Dodiya (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-594332-opw-ado
Merge into: lp:openobject-addons/6.0
Diff against target: 12 lines (+1/-1)
1 file modified
stock/wizard/stock_change_standard_price.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-594332-opw-ado
Reviewer Review Type Date Requested Status
Numérigraphe (community) Approve
Xavier ALT Pending
Naresh(OpenERP) Pending
Review via email: mp+171254@code.launchpad.net

Description of the change

Hello,

[FIX] stock: decimal precision of new_price field on update cost price wizard is not same as defined in cost_price field

Issue:
Decimal precision of field "Cost Price" in change standard price wizard should be same as "Cost Price" field of product.

Regards,
Amit

To post a comment you must log in.
Revision history for this message
Numérigraphe (numerigraphe) wrote :

That won't work because osv_memory does not honor precision attributes in v6.0

review: Needs Fixing
Reply
Revision history for this message
Numérigraphe (numerigraphe) wrote :

The patch is actually correct, only bug #800970 must be fixed too.
So when merging this into addons/6.0, please also merge lp:~openerp-dev/openobject-server/6.0-bug-800970-ysa into server/6.0.
Lionel Sausin.

review: Approve (needs server fix too)
Reply
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Another detail: the commit does reference the bug number. Please uncommit and recommit with --fixes lp:1194403.
Lionel Sausin.

review: Needs Resubmitting (missing bug reference)
Reply
lp:~openerp-dev/openobject-addons/6.0-594332-opw-ado updated
5486. By Amit Dodiya (OpenERP)

[FIX] stock: decimal precision of new_price field on update cost price wizard is not same as defined in cost_price field

Revision history for this message
Numérigraphe (numerigraphe) :
review: Approve
Reply

Unmerged revisions

5486. By Amit Dodiya (OpenERP)

[FIX] stock: decimal precision of new_price field on update cost price wizard is not same as defined in cost_price field

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/wizard/stock_change_standard_price.py'
2--- stock/wizard/stock_change_standard_price.py 2012-02-14 11:00:47 +0000
3+++ stock/wizard/stock_change_standard_price.py 2013-06-26 12:20:33 +0000
4@@ -27,7 +27,7 @@
5 _name = "stock.change.standard.price"
6 _description = "Change Standard Price"
7 _columns = {
8- 'new_price': fields.float('Price', required=True, digits_compute=dp.get_precision('Account'),
9+ 'new_price': fields.float('Price', required=True, digits_compute=dp.get_precision('Purchase Price'),
10 help="If cost price is increased, stock variation account will be debited "
11 "and stock output account will be credited with the value = (difference of amount * quantity available).\n"
12 "If cost price is decreased, stock variation account will be creadited and stock input account will be debited."),