Merge lp:~openerp-dev/openerp-web/trunk-tooltip-menu into lp:openerp-web

Proposed by Vidhin Mehta (OpenERP)
Status: Merged
Approved by: Richard Mathot (Odoo, formerly OpenERP)
Approved revision: 3989
Merged at revision: 4012
Proposed branch: lp:~openerp-dev/openerp-web/trunk-tooltip-menu
Merge into: lp:openerp-web
Diff against target: 14 lines (+4/-0)
1 file modified
addons/web/static/src/js/chrome.js (+4/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-tooltip-menu
Reviewer Review Type Date Requested Status
Richard Mathot (Odoo, formerly OpenERP) (community) Approve
OpenERP R&D Web Team Pending
Review via email: mp+216444@code.launchpad.net
To post a comment you must log in.
3985. By Vidhin Mehta (OpenERP)

[FIX]destroy tooltip because after expanding inner menu, paren menu ellipsis deactived.

3986. By Vidhin Mehta (OpenERP)

[MERGE]Trunk.

3987. By Vidhin Mehta (OpenERP)

[MERGE]Trunk.

Revision history for this message
Richard Mathot (Odoo, formerly OpenERP) (rim-openerp) wrote :

red on runbot

review: Needs Fixing
3988. By Vidhin Mehta (OpenERP)

[MERGE]Trunk.

3989. By Richard Mathot (Odoo, formerly OpenERP)

[IMP] Tooltip placement

Revision history for this message
Richard Mathot (Odoo, formerly OpenERP) (rim-openerp) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/chrome.js'
2--- addons/web/static/src/js/chrome.js 2014-04-23 12:37:35 +0000
3+++ addons/web/static/src/js/chrome.js 2014-05-08 13:41:24 +0000
4@@ -859,6 +859,10 @@
5 $clicked_menu.parent().addClass('active');
6 }
7 }
8+ // add a tooltip to cropped menu items
9+ this.$secondary_menus.find('.oe_secondary_submenu li a span').each(function() {
10+ $(this).tooltip(this.scrollWidth > this.clientWidth ? {title: $(this).text().trim(), placement: 'auto right'} :'destroy');
11+ });
12 },
13 /**
14 * Call open_menu with the first menu_item matching an action_id