Merge lp:~openerp-dev/openerp-web/trunk-opw-1013636-port-psa into lp:openerp-web

[Paramjit Singh Sahota(OpenERP)]

One2many widget does not honour being 'required'.

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi,

I notice that this branch does not include the visual hints from my original proposal:

https://code.launchpad.net/~therp-nl/openerp-web/7.0-lp1013636-x2m_honour_required_attribute/+merge/116238

Is it not bad usability not to give these hints?

Cheers,
Stefan.

[Olivier Dony (Odoo) (odo-openerp)]

There is already a merge proposal for trunk (and for 6.1) associated with this bug report, and it has been reviewed and improved already. Please don't waste time copying/redoing existing work, and use the contributed patch. Thanks!

review: Disapprove

Unmerged revisions

3483. By Paramjit Singh Sahota(OpenERP) on 2012-11-23

[IMP][Trunk] One2many widget does not honour being 'required'

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2012-11-22 13:35:55 +0000
+++ addons/web/static/src/js/view_form.js	2012-11-23 07:08:21 +0000
@@ -3602,6 +3602,9 @@
         }
         return $.when(false);
     },
+    is_false: function() {
+        return this.dataset.ids.length == 0;
+    },
     is_syntax_valid: function() {
         if (! this.viewmanager || ! this.viewmanager.views[this.viewmanager.active_view])
             return true;