Merge lp:~openerp-dev/openerp-web/trunk-improve-web-kanban-bth into lp:~openerp-dev/openerp-web/trunk-improve-web-issues-ps-w45

Proposed by Bhumi Thakkar (Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/trunk-improve-web-kanban-bth
Merge into: lp:~openerp-dev/openerp-web/trunk-improve-web-issues-ps-w45
Diff against target: 37 lines (+3/-2)
3 files modified
addons/web_kanban/static/src/css/kanban.css (+1/-1)
addons/web_kanban/static/src/css/kanban.sass (+1/-1)
addons/web_kanban/static/src/js/kanban.js (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-improve-web-kanban-bth
Reviewer Review Type Date Requested Status
Christophe Matthieu (OpenERP) Disapprove
Review via email: mp+135366@code.launchpad.net

Description of the change

Hello,

   Issue: 'create a high number of tasks in a project (or any kanban view) and click on show more at the bottom of the page: layout problems'.

Fixed call the function to set heights after click on show more records button abd change display inline-block to inline-table.

Thanks.

To post a comment you must log in.
Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Hi,
I can't reproduce this bug.
When I click on "Show more... 226 remaining" there are no problems (for chromium or firefox).

review: Abstain
Revision history for this message
Bhumi Thakkar (Open ERP) (bth-openerp) wrote :

Hello,

  To reproduce this bug follow the following steps:

1. Menu Project => Project => Projects
2. In kanban view click on "Show more...9 remaining"

Observed: Records do not display properly and records do not display on same position. Some kanban box's height is set and after click on show more remaining button remaining records' kanban box' height is not set properly.
Expected: Height of all kanban records should set properly and displayed in same position, not up and down.

Thanks.

Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

It's fixed with a vertcal-align: top not with a inline-table.
lp:~openerp-dev/openerp-web/trunk-fix-kanban-chm

review: Disapprove

Unmerged revisions

3467. By Bhumi Thakkar (Open ERP)

[FIX] Improve code to set height of kanban records after click on show more button in kanban view.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/css/kanban.css'
2--- addons/web_kanban/static/src/css/kanban.css 2012-11-15 14:30:59 +0000
3+++ addons/web_kanban/static/src/css/kanban.css 2012-11-21 10:53:21 +0000
4@@ -277,7 +277,7 @@
5 width: 100%;
6 }
7 .openerp .oe_kanban_view.oe_kanban_ungrouped .oe_kanban_column .oe_kanban_record {
8- display: inline-block;
9+ display: inline-table;
10 padding: 2px;
11 box-sizing: border-box;
12 -moz-box-sizing: border-box;
13
14=== modified file 'addons/web_kanban/static/src/css/kanban.sass'
15--- addons/web_kanban/static/src/css/kanban.sass 2012-11-15 14:30:59 +0000
16+++ addons/web_kanban/static/src/css/kanban.sass 2012-11-21 10:53:21 +0000
17@@ -264,7 +264,7 @@
18 width: 100%
19 &.oe_kanban_ungrouped .oe_kanban_column
20 .oe_kanban_record
21- display: inline-block
22+ display: inline-table
23 padding: 2px
24 box-sizing: border-box
25 -moz-box-sizing: border-box
26
27=== modified file 'addons/web_kanban/static/src/js/kanban.js'
28--- addons/web_kanban/static/src/js/kanban.js 2012-11-15 18:17:30 +0000
29+++ addons/web_kanban/static/src/js/kanban.js 2012-11-21 10:53:21 +0000
30@@ -650,6 +650,7 @@
31 self.view.dataset.ids.push(r.id);
32 });
33 self.do_add_records(records);
34+ self.compute_cards_auto_height();
35 return records;
36 });
37 },

Subscribers

People subscribed via source and target branches

to all changes: