Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-dev/openerp-web/trunk-bug-880804-ysa into lp:openerp-web

  1. trunk-bug-880804-ysa
  2. Merge into trunk
Proposed by Yogesh (SerpentCS)
Status: Rejected
Rejected by: Fabien Meghazi (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-bug-880804-ysa
Merge into: lp:openerp-web
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/xml/base.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-bug-880804-ysa
Reviewer Review Type Date Requested Status
OpenERP R&D Web Team Pending
Review via email: mp+80206@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Fabien Meghazi (OpenERP) (fme) wrote :

I prefer a flag to be set in the controller instead of checking the condition in the template.
Besides, you should check implicitly for 'True' or '1'. AFAIK, nothing forbids the usage of password="False"

+ Remember readonly widgets !

See Revision:
1369 revid:<email address hidden>

Unmerged revisions

1339. By Yogesh (SerpentCS)

[FIX] if attr has password true then set type is passowrd otherwise text.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/xml/base.xml'
2--- addons/web/static/src/xml/base.xml 2011-10-24 08:48:53 +0000
3+++ addons/web/static/src/xml/base.xml 2011-10-24 12:40:28 +0000
4@@ -768,7 +768,7 @@
5 <p class="oe_form_paragraph"><t t-esc="widget.string"/></p>
6 </t>
7 <t t-name="FieldChar">
8- <input type="text" size="1"
9+ <input t-attf-type="{widget.node.attrs.password ? 'password' : 'text'}" size="1"
10 t-att-name="widget.name"
11 t-att-id="widget.element_id"
12 t-attf-class="field_#{widget.type}"