Merge lp:~openerp-dev/openerp-web/trunk-bug-878108-kbh into lp:openerp-web

[Khushboo Bhatt(openerp)]

"The issue of checkbutton select all/none in tree view."

[Xavier (Open ERP) (xmo-deactivatedaccount)]

* Don't use IDs, there's a risk it's going to break with multiple lists present on the screen (and in any case it's not semantically correct).
* The code is short and not expected to be overridden (I'd think), so I'd suggest keeping it inline, not split as a separate method.
* Could you try using .prop() instead of .attr? I'm pretty sure it'd work just as well, and that's what it's for (technically, we're manipulating the "checked" attribute)
* Your setting of the check state looks very debatable, from what I understand it's going to set all checkboxes to the opposite of what the first one is, irrespective of what the checkbox which was just clicked is. So if you check the header checkbox, then uncheck the first row's checkbox, and uncheck the header checkbox… it's going to keep everything checked (and re-check the first row).
* I don't see the point of using `:checkbox` in your selector (in `this.$element.find('.oe-record-selector :checkbox')`): there's only ever a single input (a checkbox) in `.oe-record-selector`, so `:checkbox` does not avoid selecting anything which should not be selected, it just makes the code slower.

review: Needs Fixing

[Khushboo Bhatt(openerp) (kbh-openerp)]

hello,

improved as per suggestion.

thank you.
kbh.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

why did you leave the old code for #all_checked?

Also, why did you go from selecting checkboxes with `.oe-record-selector :checkbox` to just `:checkbox`?

review: Needs Information

[Khushboo Bhatt(openerp) (kbh-openerp)]

> why did you leave the old code for #all_checked?
- it is my mistake for left the old code so i remove it.

> Also, why did you go from selecting checkboxes with `.oe-record-selector
> :checkbox` to just `:checkbox`?
-from :checkbox i can get checkbox of all records thats why i use it.

thanks,
kbh.

=== modified file 'addons/web/static/src/js/view_list.js'
--- addons/web/static/src/js/view_list.js	2011-10-20 16:22:55 +0000
+++ addons/web/static/src/js/view_list.js	2011-10-25 06:28:24 +0000
@@ -201,8 +201,12 @@
         this.setup_columns(this.fields_view.fields, grouped);
 
         this.$element.html(QWeb.render("ListView", this));
-
         // Head hook
+        this.$element.find('.all-record-selector').click(function(){
+            self.$element.find(':checkbox').prop('checked', 
+                self.$element.find('.all-record-selector').prop('checked')  || false);
+        });
+
         this.$element.find('.oe-list-add')
                 .click(this.do_add_record)
                 .attr('disabled', grouped && this.options.editable);
@@ -269,6 +273,7 @@
             this.set_common_sidebar_sections(this.sidebar);
         }
     },
+
     /**
      * Configures the ListView pager based on the provided dataset's information
      *
@@ -650,6 +655,7 @@
             $first_header.attr('colspan', parseInt(colspan, 10) + count);
         }
         // Padding for column titles, footer and data rows
+
         var $rows = this.$element
                 .find('.oe-listview-header-columns, tr:not(thead tr)')
                 .not(options['except']);

=== modified file 'addons/web/static/src/xml/base.xml'
--- addons/web/static/src/xml/base.xml	2011-10-24 15:20:56 +0000
+++ addons/web/static/src/xml/base.xml	2011-10-25 06:28:24 +0000
@@ -579,7 +579,8 @@
                     <t t-esc="column.string"/>
                 </th>
             </t>
-            <th t-if="options.selectable" width="1"/>
+            <th t-if="options.selectable" width="1"  >
+                <input type="checkbox" class="all-record-selector"/> </th>
             <t t-foreach="columns" t-as="column">
                 <th t-if="!column.meta and column.invisible !== '1'" t-att-data-id="column.id"
                     t-att-class="((options.sortable and column.tag !== 'button') ? 'oe-sortable' : null)">