Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-dev/openerp-web/trunk-bug-876518-vda into lp:openerp-web

  1. trunk-bug-876518-vda
  2. Merge into trunk
Proposed by Vaibhav Darji
Status: Rejected
Rejected by: Nicolas Vanhoren (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-bug-876518-vda
Merge into: lp:openerp-web
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/js/view_form.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-bug-876518-vda
Reviewer Review Type Date Requested Status
Nicolas Vanhoren (OpenERP) (community) Needs Fixing
Review via email: mp+79654@code.launchpad.net

Description of the change

Readonly m2m.

To post a comment you must log in.
lp:~openerp-dev/openerp-web/trunk-bug-876518-vda updated
1285. By Vaibhav Darji

[FIX] does not remove readonly m2m records.

1286. By Vaibhav Darji

[FIX] Fix.

Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

Will to work also when there is an on_change, readonly flag should be checked in the update_dom method.

review: Needs Fixing
lp:~openerp-dev/openerp-web/trunk-bug-876518-vda updated
1287. By Vaibhav Darji

[MERGE] trunk.

Unmerged revisions

1287. By Vaibhav Darji

[MERGE] trunk.

1286. By Vaibhav Darji

[FIX] Fix.

1285. By Vaibhav Darji

[FIX] does not remove readonly m2m records.

1284. By Vaibhav Darji

[FIX] not able to add record in m2m when readonly.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2011-10-27 12:43:25 +0000
3+++ addons/web/static/src/js/view_form.js 2011-10-31 07:14:26 +0000
4@@ -2286,7 +2286,7 @@
5 var self = this;
6 this.list_view = new openerp.web.form.Many2ManyListView(this, this.dataset, false, {
7 'addable': self.readonly ? null : 'Add',
8- 'deletable': self.readonly ? false : true,
9+ 'deletable': !self.readonly,
10 'selectable': self.multi_selection
11 });
12 this.list_view.m2m_field = this;