Merge lp:~openerp-dev/openerp-web/trunk-bug-1211305 into lp:openerp-web

Proposed by Thibault Delavallée (OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-bug-1211305
Merge into: lp:openerp-web
Diff against target: 15 lines (+5/-0)
1 file modified
addons/web/http.py (+5/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-bug-1211305
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Thibault Delavallée (OpenERP) (community) Needs Information
Review via email: mp+190311@code.launchpad.net

Description of the change

I don't know because people seems to want me to merge things without merge proposal.

To post a comment you must log in.
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

Please fill a bug report with a way to reproduce your bug, so we can check that effectively something is solved.

Best regards,

Thibault.

review: Needs Information
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

If the cleanup of the session_id key was too early, maybe it could just have been moved down instead of duplicating it entirely...

review: Disapprove

Unmerged revisions

3830. By Amit Bhavsar (Open ERP)

[Import] solved the import error 404.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/http.py'
2--- addons/web/http.py 2013-10-04 08:46:18 +0000
3+++ addons/web/http.py 2013-10-10 08:52:43 +0000
4@@ -409,6 +409,11 @@
5 self.params = params
6
7 def dispatch(self):
8+ ex = set(["session_id"])
9+ for k in self.params.keys():
10+ if k in ex:
11+ del self.params[k]
12+
13 akw = {}
14 for key, value in self.httprequest.args.iteritems():
15 if isinstance(value, basestring) and len(value) < 1024: