Merge lp:~openerp-dev/openerp-web/trunk-bug-1119289-dhruvit into lp:openerp-web

[Dhruvit Darji(OpenERP)]

Hello,

   I have fixed the issue of Wastage of view space in journal entries

Thanks,
Dhruvit.

[lp:~openerp-dev/openerp-web/trunk-bug-1119289-dhruvit]

3701. By Dhruvit Darji(OpenERP) on 2013-03-22

[IMP] Remove unused space

[Stefan Rijnhart (Opener) (stefan-opener)]

Commit 3701 undoes the fix of the problem from commit 3700.

review: Needs Fixing

[Nimesh Contractor(Open ERP) (nco-openerp)]

Following are two different approach to fix this issue:

1) Revision 3700 : For large one2many field(too many columns) it will re-sized the sheet

2) Revision 3701 : It will add scroll bar in one2many field and keep sheet size at it is (850px)

review: Needs Information

[Stefan Rijnhart (Opener) (stefan-opener)]

Nimesh,

to be more precise about this: rev. 3701 is a refactoring of https://code.launchpad.net/~openerp-dev/openerp-web/7.0-opw-589823-msh. This fixes a bug in which the columns break out of the page layout, and it adds the scrollbar. Now, if you take a look at the screenshot that demonstrates the issue (in the bug's first comment), you will see that the scollbar is already there. Camp2camp must have gotten that as an OPW fix. The bug's description clearly complains about the unused space in combination with the scrollbar and the cramped one2many layout. Therefore, revision 3700 fixes the problem and revision 3701 reverts it again.

Dhruvit, please revert revision 3701 and we are done. Yes, this resizes the sheet which is a huge improvement on usability.

Unmerged revisions

3701. By Dhruvit Darji(OpenERP) on 2013-03-22

[IMP] Remove unused space

3700. By Dhruvit Darji(OpenERP) on 2013-03-13

[FIX] Remove the waste space in journal entry

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2013-03-15 09:01:12 +0000
+++ addons/web/static/src/css/base.css	2013-03-22 09:26:41 +0000
@@ -2137,7 +2137,7 @@
   min-height: 330px;
   padding: 16px;
 }
-.openerp .oe_form_sheet .oe_list {
+.openerp .oe_form_sheet .oe_form_field_one2many, .openerp .oe_form_sheet .oe_form_field_many2many {
   overflow-x: auto;
 }
 .openerp .oe_application .oe_form_sheetbg {

=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass	2013-03-15 09:01:12 +0000
+++ addons/web/static/src/css/base.sass	2013-03-22 09:26:41 +0000
@@ -1683,13 +1683,13 @@
         padding: 16px 0
     .oe_form_sheet_width
         min-width: 650px
-        max-width: $sheet-max-width
+        max-width: 860px
         margin: 0 auto
     .oe_form_sheet
         background: white
         min-height: 330px
         padding: 16px
-        .oe_list
+        .oe_form_field_one2many, .oe_form_field_many2many
             overflow-x: auto
     // Sheet inline mode
     .oe_application