Merge lp:~openerp-dev/openerp-web/trunk-bug-1101840-bth into lp:openerp-web

[Bhumi Thakkar (Open ERP)]

Hello,

    Fixed issue of group by on search view. If current model and model of context in action (active_model) are same then pass group by of context in action like action.context.group_by else [].
If models are different and passed fields in group by of context in action and if passed field is not in current model then will get error. Because of that this issue is raised and fixed by condition of matched model.

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello,

It has already been fixed in revision 3888 with better fix, also the current fix was removing default groupy_by of action context.

For now there is no need of this branch as it has already been merged in trunk.

Thanks.

[Bern Schneider (mia-11ngola)]

Hello,

This patch resolve this bug but in dashboard, all filters are lost!!

Is there more solutions about that??

Thx,
Vitasoa

Unmerged revisions

3750. By Nicolas JEUDY (njeudy) on 2013-06-07

[IMP]If model and action_context's model are same then passed group by of action_context else [].

=== modified file 'addons/web/static/src/js/views.js'
--- addons/web/static/src/js/views.js	2013-05-23 05:14:07 +0000
+++ addons/web/static/src/js/views.js	2013-06-07 09:09:54 +0000
@@ -767,9 +767,12 @@
         }).done(function (results) {
             self.dataset._model = new instance.web.Model(
                 self.dataset.model, results.context, results.domain);
+            var default_groupby = (self.dataset.model === action_context.active_model)
+                ? action_context.group_by
+                : [];
             var groupby = results.group_by.length
                         ? results.group_by
-                        : action_context.group_by;
+                        : default_groupby;
             if (_.isString(groupby)) {
                 groupby = [groupby];
             }