Merge lp:~openerp-dev/openerp-web/trunk-bug-1092942-ggh into lp:openerp-web

[Farid Ghanchi]

Hello,

I had improve the code in kanban view tags are superimposed,
In code missing a class, not find the oe_tags class so view are not proper so add the class.
Now kanban view tags issue fixed.

Thanks
[GGH]

[Christophe Matthieu (OpenERP) (chm-openerp)]

Hi,
The margin-right should be set to 0 for the oe_tags box.
Why you use span in place of the element oe_tag ?
This fix does not correct the view card.
Thanks.

review: Needs Fixing

[lp:~openerp-dev/openerp-web/trunk-bug-1092942-ggh]

3661. By Farid Ghanchi on 2012-12-31

improved code for oe_tags box

[Farid Ghanchi (gfarid)]

Hello,

The margin-right should be set to 0 for the oe_tags box.
I have use oe_tag class in place of span
yes its differnt behaviour in box like :
                  hours(oe_e) are view differ
                  oe_tag color are differ.
so now correct the view card.

Thanks...
[GGH]

review: Needs Resubmitting

[Christophe Matthieu (OpenERP) (chm-openerp)]

Hi,
I see that some values set in .openerp .oe_tag (sory I don't saw that before), could you remove the color, border, border-radius attributes, and set line-height: 14px;
Thanks.

review: Needs Fixing

[Christophe Matthieu (OpenERP) (chm-openerp)]

Could you fix Bug#1094877 in same time.
(Apply change on .openerp .oe_kanban_view instead of .openerp .oe_kanban_view .oe_kanban_footer_left, I think it will be good)
Thanks

[lp:~openerp-dev/openerp-web/trunk-bug-1092942-ggh]

3662. By Farid Ghanchi on 2013-01-02

[Fix] Fixed the issue of action number cut in kanban(bug#1094877)

[Farid Ghanchi (gfarid)]

Hello sir,

Yes,Its just like a same bug#1094887
So I had add a class *oe_kanban_group_title* in *display* property set.
Now not cut action number in kanban view with long column names when Edit.

Thanks

review: Needs Resubmitting

[lp:~openerp-dev/openerp-web/trunk-bug-1092942-ggh]

3663. By Farid Ghanchi on 2013-01-02

I had remove the color, border, border-radius attributes

[Christophe Matthieu (OpenERP) (chm-openerp)]

Hi,
Good, please see previous comments about use .oe_tag and excess attributes
Thanks

review: Needs Fixing

[Farid Ghanchi (gfarid)]

Hello sir,

I had remove some attribute in *oe_tags* as you suggest..

Thanks

review: Needs Resubmitting

=== modified file 'addons/web_kanban/static/src/css/kanban.css'
--- addons/web_kanban/static/src/css/kanban.css	2012-12-20 18:39:42 +0000
+++ addons/web_kanban/static/src/css/kanban.css	2013-01-02 13:41:23 +0000
@@ -84,6 +84,7 @@
 }
 .openerp .oe_kanban_view .oe_kanban_group_title > span {
   margin-right: 4px;
+  display: inline-block;
 }
 .openerp .oe_kanban_view .oe_kanban_column, .openerp .oe_kanban_view .oe_kanban_group_header {
   vertical-align: top;
@@ -432,6 +433,14 @@
   line-height: 12px;
   font-size: 22px;
 }
+.openerp .oe_kanban_view .oe_kanban_footer_left .oe_tags {
+  margin-right: 0;
+}
+.openerp .oe_kanban_view .oe_kanban_footer_left .oe_tags .oe_tag {
+  display: inline-block;
+  padding: 0 2px;
+  line-height: 14px;
+}
 .openerp .oe_kanban_view .oe_kanban_footer_left .oe_kanban_mail_new {
   line-height: 18px;
   background-color: #8a89ba;

=== modified file 'addons/web_kanban/static/src/css/kanban.sass'
--- addons/web_kanban/static/src/css/kanban.sass	2012-12-20 18:39:42 +0000
+++ addons/web_kanban/static/src/css/kanban.sass	2013-01-02 13:41:23 +0000
@@ -111,6 +111,7 @@
         text-shadow: 0 1px 0 white
         > span
             margin-right: 4px
+            display: inline-block
 
     .oe_kanban_column, .oe_kanban_group_header
         vertical-align: top
@@ -381,6 +382,12 @@
             .oe_e
                 line-height: 12px
                 font-size: 22px
+        .oe_tags
+            margin-right: 0
+            .oe_tag
+                display: inline-block
+                padding: 0 2px
+                line-height: 14px
         .oe_kanban_mail_new
             line-height: 18px
             background-color: #8a89ba