Merge lp:~openerp-dev/openerp-web/trunk-bug-1011492-pan into lp:openerp-web

[Jiten (OpenERP)]

[Jiten (OpenERP) (jiten-openerp)]

review: Approve

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Looking at that code, it bothers me that the behavior seems arbitrary and lucky, it makes the error disappear but doesn't actually fix it: it's relying on the implementation behavior of min wrt `undefined`, and then relies on the inequality test wrt 0 for the definition of the axis min values.

The way I'd see to do that, _.min returns ``undefined`` if the list of values is empty, instead of pre-testing and returning some arbitrary value use [null, Infinity] as the inner min

    var record_min = _.min(record.data, function (item) {
        return item[1];
    }) || [null, Infinity];
    return record_min[1];

this ensures the second member is as big as can be, and will always correctly behave in other mins, and in comparisons with `0`.

review: Needs Fixing

[Nicolas Vanhoren (OpenERP) (niv-openerp)]

No more useful fix because the problem does not appear any more.

Unmerged revisions

2885. By Anand on 2012-09-03

[IMP]I have updated the code as suggested

2884. By Anand on 2012-09-03

[MERGE]Merged from openerp-web

2883. By Anand on 2012-08-29

[FIX]fixes the dashboard problem for the sales and hr graph

2882. By Anand on 2012-08-29

[MERGE]Merged from openerp web

2881. By Anand on 2012-08-28

[MERGE]Merged from openerp web

2880. By Anand on 2012-08-27

[MERGE]mergerd form openerp-web

2879. By Anand on 2012-08-20

[MERGE]merged from openerp-web

2878. By Anand on 2012-08-17

[MERGE] merged from the openerp-web

2877. By Anand on 2012-08-16

[MERGE]merged from openerp-web

2876. By Anand on 2012-08-13

[IMP]updated code for sales and hr graph

=== modified file 'addons/web_graph/static/src/js/graph.js'
--- addons/web_graph/static/src/js/graph.js	2012-08-24 18:27:07 +0000
+++ addons/web_graph/static/src/js/graph.js	2012-09-03 10:35:44 +0000
@@ -142,9 +142,10 @@
     options_bar: function (data) {
         var min = _(data.data).chain()
             .map(function (record) {
-                return _.min(record.data, function (item) {
+                var record_min = _.min(record.data, function (item) {
                     return item[1];
-                })[1];
+                }) || [null, Infinity];
+                return record_min[1];
             }).min().value();
         return {
             bars : {