Merge lp:~openerp-dev/openerp-web/trunk-bs3-jke-mme into lp:~openerp-dev/openerp-web/trunk-bs3-jke

Proposed by Mehul Mehta(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/trunk-bs3-jke-mme
Merge into: lp:~openerp-dev/openerp-web/trunk-bs3-jke
Diff against target: 142 lines (+35/-16)
7 files modified
addons/web/static/src/css/base-form.css (+3/-2)
addons/web/static/src/css/base-form.sass (+2/-1)
addons/web/static/src/css/base.css (+10/-1)
addons/web/static/src/css/base.sass (+9/-0)
addons/web/static/src/js/view_form.js (+2/-5)
addons/web/static/src/js/view_list.js (+4/-2)
addons/web/static/src/xml/base.xml (+5/-5)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-bs3-jke-mme
Reviewer Review Type Date Requested Status
OpenERP R&D Team Pending
Review via email: mp+204181@code.launchpad.net

Description of the change

Hello,

    replace the jquery progressbar using bootstrap progressbar and replace oe_form_field_boolean to checkbox-inline in FieldBoolean template and add btn-sm btn-default in WidgetButton template.

    - add class in addons/web/static/src/css/base.sass
    - add class in addons/web/static/src/css/base.css
    - add class in addons/web/static/src/css/base-form.css
    - add class in addons/web/static/src/css/base-form.sass
    - improved code in addons/web/static/src/js/view_form.js
    - improved code in addons/web/static/src/js/view_list.js
    - improved code in addons/web/static/src/xml/base.xml

Please review it.

Thank you.

To post a comment you must log in.

Unmerged revisions

3922. By Pariket Trivedi(OpenERP)

[IMP] : FieldBoolean template add checkbox-inline instead of oe_form_field_booleanand WidgetButton template add btn-sm btn-default.

3921. By Mehul Mehta(OpenERP)

[Fix] improvement progressbar

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base-form.css'
2--- addons/web/static/src/css/base-form.css 2014-01-22 14:34:14 +0000
3+++ addons/web/static/src/css/base-form.css 2014-01-31 10:28:33 +0000
4@@ -199,8 +199,9 @@
5 .openerp .oe_form .oe_form_field_date,
6 .openerp .oe_form .oe_form_field_datetime {
7 white-space: nowrap; }
8- .openerp .oe_form .oe_form_field_boolean {
9- width: auto; }
10+ .openerp .oe_form .checkbox-inline {
11+ width: auto;
12+ vertical-align: middle !important; }
13 .openerp .oe_form .oe_datepicker_container {
14 display: none; }
15 .openerp .oe_form .oe_datepicker_root {
16
17=== modified file 'addons/web/static/src/css/base-form.sass'
18--- addons/web/static/src/css/base-form.sass 2014-01-27 12:21:18 +0000
19+++ addons/web/static/src/css/base-form.sass 2014-01-31 10:28:33 +0000
20@@ -302,8 +302,9 @@
21 .oe_form_field_date,
22 .oe_form_field_datetime
23 white-space: nowrap
24- .oe_form_field_boolean
25+ .checkbox-inline
26 width: auto
27+ vertical-align: middle !important
28 .oe_datepicker_container
29 display: none
30 .oe_datepicker_root
31
32=== modified file 'addons/web/static/src/css/base.css'
33--- addons/web/static/src/css/base.css 2014-01-27 12:21:18 +0000
34+++ addons/web/static/src/css/base.css 2014-01-31 10:28:33 +0000
35@@ -1,4 +1,4 @@
36-@charset "utf-8";
37+@charset "UTF-8";
38 .openerp {
39 font-family: "Lucida Grande", Helvetica, Verdana, Arial, sans-serif;
40 color: #4c4c4c;
41@@ -1097,3 +1097,12 @@
42
43 .oe_view_manager_new .oe_form_nosheet {
44 margin-top: 8px; }
45+
46+.progress {
47+ height: 15px;
48+ margin-bottom: 0px;
49+ font-size: 10px; }
50+
51+.progress-bar {
52+ background-color: #428bca;
53+ color: #050404; }
54
55=== modified file 'addons/web/static/src/css/base.sass'
56--- addons/web/static/src/css/base.sass 2014-01-27 12:21:18 +0000
57+++ addons/web/static/src/css/base.sass 2014-01-31 10:28:33 +0000
58@@ -1320,3 +1320,12 @@
59
60 // au BufWritePost,FileWritePost *.sass :!sass --style expanded --line-numbers <afile> > "%:p:r.css"
61 // vim:tabstop=4:shiftwidth=4:softtabstop=4:fdm=marker:
62+
63+.progress
64+ height: 15px
65+ margin-bottom: 0px
66+ font-size: 10px
67+
68+.progress-bar
69+ background-color: #428bca
70+ color: #050404
71\ No newline at end of file
72
73=== modified file 'addons/web/static/src/js/view_form.js'
74--- addons/web/static/src/js/view_form.js 2014-01-27 12:21:18 +0000
75+++ addons/web/static/src/js/view_form.js 2014-01-31 10:28:33 +0000
76@@ -2796,12 +2796,9 @@
77 instance.web.form.FieldProgressBar = instance.web.form.AbstractField.extend({
78 template: 'FieldProgressBar',
79 render_value: function() {
80- this.$el.progressbar({
81- value: this.get('value') || 0,
82- disabled: this.get("effective_readonly")
83- });
84 var formatted_value = instance.web.format_value(this.get('value') || 0, { type : 'float' });
85- this.$('span').html(formatted_value + '%');
86+ this.$('div.progress-bar').html(formatted_value + '%');
87+ this.$('div.progress-bar').css({'width':formatted_value + '%'});
88 }
89 });
90
91
92=== modified file 'addons/web/static/src/js/view_list.js'
93--- addons/web/static/src/js/view_list.js 2014-01-24 12:47:21 +0000
94+++ addons/web/static/src/js/view_list.js 2014-01-31 10:28:33 +0000
95@@ -2320,8 +2320,10 @@
96 */
97 _format: function (row_data, options) {
98 return _.template(
99- '<progress value="<%-value%>" max="100"><%-value%>%</progress>', {
100- value: _.str.sprintf("%.0f", row_data[this.id].value || 0)
101+ '<div class="progress">
102+ <div class="progress-bar" role="progressbar" style="width: <%-value%>%"><%-value%>%</div>
103+ </div>', {
104+ value: instance.web.format_value(row_data[this.id].value || 0, { type : 'float' })
105 });
106 }
107 });
108
109=== modified file 'addons/web/static/src/xml/base.xml'
110--- addons/web/static/src/xml/base.xml 2014-01-27 12:21:18 +0000
111+++ addons/web/static/src/xml/base.xml 2014-01-31 10:28:33 +0000
112@@ -1220,7 +1220,7 @@
113 </table>
114 </t>
115 <t t-name="FieldBoolean">
116- <span class="oe_form_field oe_form_field_boolean" t-att-style="widget.node.attrs.style">
117+ <span class="oe_form_field checkbox-inline" t-att-style="widget.node.attrs.style">
118 <input type="checkbox"
119 t-att-id="widget.id_for_label"
120 t-att-name="widget.name"
121@@ -1230,9 +1230,9 @@
122 </span>
123 </t>
124 <t t-name="FieldProgressBar">
125- <span class="oe_form_field oe_form_field_progressbar" t-att-style="widget.node.attrs.style">
126- <span></span>
127- </span>
128+ <div class="progress">
129+ <div class="progress-bar" role="progressbar"></div>
130+ </div>
131 </t>
132 <t t-name="FieldStatus">
133 <ul t-att-class="'oe_form_field_status ' + (widget.options.clickable ? 'oe_form_status_clickable' : 'oe_form_status')" t-att-style="widget.node.attrs.style"/>
134@@ -1397,7 +1397,7 @@
135 </div>
136 </t>
137 <t t-name="WidgetButton">
138- <button type="button" class="btn oe_form_button"
139+ <button type="button" class="btn btn-sm btn-default oe_form_button"
140 t-att-style="widget.node.attrs.style"
141 t-att-tabindex="widget.node.attrs.tabindex"
142 t-att-autofocus="widget.node.attrs.autofocus"

Subscribers

People subscribed via source and target branches

to all changes: