Merge lp:~openerp-dev/openerp-web/saas-3-opw-606213-acl into lp:~openerp/openerp-web/saas-3

Proposed by Martin Trigaux (OpenERP)
Status: Rejected
Rejected by: Martin Trigaux (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/saas-3-opw-606213-acl
Merge into: lp:~openerp/openerp-web/saas-3
Diff against target: 28 lines (+3/-3)
1 file modified
addons/web_graph/static/src/js/pivot_table.js (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/saas-3-opw-606213-acl
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+217562@code.launchpad.net

Description of the change

fixing pivot table errors

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

better fix done in saas-4

Unmerged revisions

3997. By Anaƫl Closson (openerp)

[FIX] web_graph: fast clicking on group by cause exceptions - opw 606213

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_graph/static/src/js/pivot_table.js'
2--- addons/web_graph/static/src/js/pivot_table.js 2014-01-28 15:11:57 +0000
3+++ addons/web_graph/static/src/js/pivot_table.js 2014-04-29 08:35:30 +0000
4@@ -238,13 +238,13 @@
5 },
6
7 make_header: function (group, parent) {
8- var title = parent ? group.attributes.value : _t('Total');
9+ var title = parent && group && group.attributes ? group.attributes.value : _t('Total');
10 return {
11 id: _.uniqueId(),
12 path: parent ? parent.path.concat(title) : [],
13 title: title,
14 children: [],
15- domain: parent ? group.model._domain : this.domain,
16+ domain: parent && group && group.model ? group.model._domain : this.domain,
17 root: parent ? parent.root : undefined,
18 };
19 },
20@@ -434,7 +434,7 @@
21 var self = this,
22 main = this.make_header(data, parent);
23
24- if (main.path.length < depth) {
25+ if (main.path.length < depth && data) {
26 main.children = _.map(data.children || data, function (data_pt) {
27 return self.make_headers (data_pt, depth, main);
28 });

Subscribers

People subscribed via source and target branches