Merge lp:~openerp-dev/openerp-web/mck-opw-579147-cbi into lp:~openerp-dev/openerp-web/6.1-web-custo-tfr

Proposed by Chris Biersbach (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/mck-opw-579147-cbi
Merge into: lp:~openerp-dev/openerp-web/6.1-web-custo-tfr
Diff against target: 30 lines (+3/-5)
2 files modified
addons/web/static/lib/jquery/jquery-1.6.4.js (+2/-4)
addons/web/static/src/js/view_form.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/mck-opw-579147-cbi
Reviewer Review Type Date Requested Status
OpenERP R&D Team Pending
Review via email: mp+143275@code.launchpad.net

Description of the change

The issue: When clicking on the button next to o2m fields, an error message appeared. A first fix by mva caused this to disappear, but the first click still wouldn't open the context menu (only present in IE8)

The cause: a bug in jquery

This branch, along with an addons branch of the same name, fix this issue. The context menu is now correctly opened.

To post a comment you must log in.

Unmerged revisions

2391. By Chris Biersbach (OpenERP)

[FIX] This, along with an addons patch, fixes the issue that the context menu is not opened in Internet Explorer 8 (shows an error)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/lib/jquery/jquery-1.6.4.js'
2--- addons/web/static/lib/jquery/jquery-1.6.4.js 2012-12-19 09:52:56 +0000
3+++ addons/web/static/lib/jquery/jquery-1.6.4.js 2013-01-15 10:58:22 +0000
4@@ -1015,11 +1015,9 @@
5 while( callbacks[ 0 ] ) {
6 callbacks.shift().apply( context, args );
7 }
8+ } catch(err) {
9+ //ie8 need a catch clause
10 }
11- catch(err)
12- {
13- //empty for ie8 need a catch
14- }
15 finally {
16 fired = [ context, args ];
17 firing = 0;
18
19=== modified file 'addons/web/static/src/js/view_form.js'
20--- addons/web/static/src/js/view_form.js 2013-01-14 10:35:27 +0000
21+++ addons/web/static/src/js/view_form.js 2013-01-15 10:58:22 +0000
22@@ -2126,7 +2126,7 @@
23 });
24 });
25 this.$menu_btn.bind({
26- click: function(e) { init_context_menu_def.resolve(e); e.preventDefault() },
27+ click: function(e) { $.when(init_context_menu_def.resolve(e)).then(function(){ e.preventDefault(); }); },
28 focus: function () { $self.trigger('widget-focus'); },
29 blur: function () {
30 if (cm_ignore_blur) { return; }

Subscribers

People subscribed via source and target branches

to all changes: