Merge lp:~openerp-dev/openerp-web/7.0-safer-cookier-mat into lp:openerp-web/7.0

Proposed by Martin Trigaux (OpenERP)
Status: Merged
Merged at revision: 4166
Proposed branch: lp:~openerp-dev/openerp-web/7.0-safer-cookier-mat
Merge into: lp:openerp-web/7.0
Diff against target: 17 lines (+6/-1)
1 file modified
addons/web/static/src/js/coresetup.js (+6/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-safer-cookier-mat
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+213034@code.launchpad.net

Description of the change

If the cookie is malformed, catch the error and delete it

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/coresetup.js'
2--- addons/web/static/src/js/coresetup.js 2013-07-02 09:39:32 +0000
3+++ addons/web/static/src/js/coresetup.js 2014-03-27 12:00:46 +0000
4@@ -125,7 +125,12 @@
5 for(var i=0; i<cookies.length; ++i) {
6 var cookie = cookies[i].replace(/^\s*/, '');
7 if(cookie.indexOf(nameEQ) === 0) {
8- return JSON.parse(decodeURIComponent(cookie.substring(nameEQ.length)));
9+ try {
10+ return JSON.parse(decodeURIComponent(cookie.substring(nameEQ.length)));
11+ } catch (err) {
12+ // delete malformed cookie
13+ this.set_cookie(name, '', -1);
14+ }
15 }
16 }
17 return null;