Merge lp:~openerp-dev/openerp-web/7.0-opw-606601-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Merged at revision: 4178
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-606601-msh
Merge into: lp:openerp-web/7.0
Diff against target: 11 lines (+1/-1)
1 file modified
addons/web/static/src/js/view_form.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-606601-msh
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Approve
Naresh(OpenERP) Pending
Review via email: mp+216413@code.launchpad.net

Description of the change

Hello,

Fixed the issue of reference field throws traceback that view is undefined, the reason is that reference field passing DefaultFieldManager while creating instance of many2one widget and DefaultFieldManager is eventually extending instance.web.widget not instance.web.form.FormWidget and hence DefaultFieldmanager will nto having view attribute, instead of calling self.view.do_onchange, trigger changed_value which is going to do the same job.

Demo:- Goto Settings -> Technical -> Parameters -> Configuration Parameters, open any record, record having one reference field, in reference field open many2one record(follow button), and change soemthing in many2one popup and then just save.

Result: Error, that self.view.do_onchange is undefined.

Expected Result: After Many2one save onchange of many2one should triggered.

Thanks.

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

LGTM, thanks

revno: 4178 [merge]
revision-id: <email address hidden>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2014-04-17 10:12:17 +0000
3+++ addons/web/static/src/js/view_form.js 2014-04-18 04:26:00 +0000
4@@ -3154,7 +3154,7 @@
5 self.display_value = {};
6 self.render_value();
7 self.focus();
8- self.view.do_onchange(self);
9+ self.trigger('changed_value');
10 });
11 });
12