Merge lp:~openerp-dev/openerp-web/7.0-opw-605931-msh into lp:openerp-web/7.0

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of duplicated one2many lines, weired behavior when you added one2many line and then add another line without filling required field and then click on save(Parent record Save button), then remove added one2many line for which we didn't filled required data and then save it, you will get duplicated lines.

Demo: To repdocue this issue please go through document given if following bug report or second video.
https://bugs.launchpad.net/openerp-web/+bug/1265705

Reason: While save the record web-client maintains save_list, so when Parent record save button is clicked it call process_operation and it commit value for each field and hence commit_Value called for one2many which saves one2many record and hence save is called for one2many form it fails and we do no handle fail call back, we should pop save_obj from save_list in fails callback.

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

LGTM, thanks

revno: 4172 [merge]
revision-id: <email address hidden>

review: Approve

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2014-03-26 12:35:13 +0000
+++ addons/web/static/src/js/view_form.js	2014-04-14 05:43:58 +0000
@@ -620,6 +620,9 @@
                         });
                     }
                     return $.when();
+                }).fail(function() {
+                    self.save_list.pop();
+                    return $.when();
                 });
             };
             return iterate();