Merge lp:~openerp-dev/openerp-web/7.0-opw-604815-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-604815-msh
Merge into: lp:openerp-web/7.0
Diff against target: 54 lines (+6/-6)
2 files modified
addons/web/static/src/js/search.js (+4/-4)
addons/web/static/src/xml/base.xml (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-604815-msh
Reviewer Review Type Date Requested Status
Xavier (Open ERP) Pending
Naresh(OpenERP) Pending
Martin Trigaux (OpenERP) Pending
Review via email: mp+210737@code.launchpad.net

Description of the change

Hello,

Advance Filter with Integer or Float field doesn't allow you to enter other decimal separator then .(dot).

Demo: Set your language configuration and add ,(comma) as a decimal separtor, now go to Chrome and try to search in advance filter for integer or float type field with value something like 455,92, You will not get expected result or you may get validation message(depends on chrome version)

Reason: We have used input field type=number and as it is number type field then you can only enter number with .(dot) as a decimal separator.

Thanks.

To post a comment you must log in.

Unmerged revisions

4151. By Mohammed Shekha(OpenERP)<email address hidden>

[FIX]Web Advance Search: Fixed the issue of Advance Search, integer or float field doesn't allow to enter other decimal then dot(.) in chrome browser.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/search.js'
2--- addons/web/static/src/js/search.js 2014-03-11 10:49:47 +0000
3+++ addons/web/static/src/js/search.js 2014-03-13 05:10:36 +0000
4@@ -2108,14 +2108,14 @@
5 {value: "∄", text: _lt("is not set")}
6 ],
7 toString: function () {
8- return this.$el.val();
9+ return instance.web.format_value(this.get_value(), {'widget': 'integer'});
10 },
11 get_value: function() {
12 try {
13 var val =this.$el.val();
14 return instance.web.parse_value(val == "" ? 0 : val, {'widget': 'integer'});
15 } catch (e) {
16- return "";
17+ return 0;
18 }
19 }
20 });
21@@ -2135,14 +2135,14 @@
22 {value: "∄", text: _lt("is not set")}
23 ],
24 toString: function () {
25- return this.$el.val();
26+ return instance.web.format_value(this.get_value(), {'widget': 'float'});
27 },
28 get_value: function() {
29 try {
30 var val =this.$el.val();
31 return instance.web.parse_value(val == "" ? 0.0 : val, {'widget': 'float'});
32 } catch (e) {
33- return "";
34+ return 0.00;
35 }
36 }
37 });
38
39=== modified file 'addons/web/static/src/xml/base.xml'
40--- addons/web/static/src/xml/base.xml 2013-10-22 16:25:19 +0000
41+++ addons/web/static/src/xml/base.xml 2014-03-13 05:10:36 +0000
42@@ -1667,10 +1667,10 @@
43 <span/>
44 </t>
45 <t t-name="SearchView.extended_search.proposition.integer">
46- <input type="number" class="field_integer" value = "0" step="1"/>
47+ <input class="field_integer" value = "0"/>
48 </t>
49 <t t-name="SearchView.extended_search.proposition.float">
50- <input type="number" class="field_float" value = "0.0" step="0.01"/>
51+ <input class="field_float" value = "0.0"/>
52 </t>
53 <t t-name="SearchView.extended_search.proposition.selection">
54 <select>