Merge lp:~openerp-dev/openerp-web/7.0-opw-603932-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Merged at revision: 4139
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-603932-msh
Merge into: lp:openerp-web/7.0
Diff against target: 79 lines (+7/-8)
3 files modified
addons/web/static/src/css/base.css (+6/-5)
addons/web/static/src/css/base.sass (+1/-0)
addons/web/static/src/js/view_form.js (+0/-3)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-603932-msh
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Approve
Xavier (Open ERP) Pending
Naresh(OpenERP) Pending
Review via email: mp+206185@code.launchpad.net

Description of the change

Hello,

Fixed the issue of statubar in chrome is aligned, it is aligned in inline block.

Demo: Run OpenERP with Chrome 31.0.1650.57 or I thin any other version 31.xx, open any form view where stausbar and button resides, say for example Customer Invoice and see button and statusbar is not inline, if you refresh the view you will not face this issue, but if you again click on Customer Invoice menu and open form view then again same issue.

Reason: In statusbar we added extra div with clear: both, not that clear:both will not allow floating elements on its both side(right and left), due to which statusbar is displayed outlined.

Thanks.

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Thanks for the fix. I have removed the sass conversion lines (utf-8 -> UTF-8, etc.) to make the diff minimal.

revno: 4139 [merge]
revision-id: <email address hidden>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2014-02-04 15:50:46 +0000
3+++ addons/web/static/src/css/base.css 2014-02-13 14:14:05 +0000
4@@ -1,4 +1,4 @@
5-@charset "utf-8";
6+@charset "UTF-8";
7 @font-face {
8 font-family: "mnmliconsRegular";
9 src: url("/web/static/src/font/mnmliconsv21-webfont.eot") format("eot");
10@@ -1029,7 +1029,7 @@
11 background-image: -moz-linear-gradient(top, #fc8787, maroon);
12 background-image: -ms-linear-gradient(top, #fc8787, maroon);
13 background-image: -o-linear-gradient(top, #fc8787, maroon);
14- background-image: linear-gradient(to bottom, #fc8787, #800000);
15+ background-image: linear-gradient(to bottom, #fc8787, maroon);
16 }
17 .openerp .oe_topbar .oe_topbar_anonymous_login a {
18 display: block;
19@@ -1275,7 +1275,7 @@
20 color: white;
21 padding: 2px 4px;
22 margin: 1px 6px 0 0;
23- border: 1px solid lightGray;
24+ border: 1px solid lightgrey;
25 text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
26 -moz-border-radius: 4px;
27 -webkit-border-radius: 4px;
28@@ -1307,7 +1307,7 @@
29 transform: scale(1.1);
30 }
31 .openerp .oe_secondary_submenu .oe_active {
32- border-top: 1px solid lightGray;
33+ border-top: 1px solid lightgrey;
34 border-bottom: 1px solid #dedede;
35 text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
36 -moz-box-shadow: inset 0 1px 3px rgba(0, 0, 0, 0.2), inset 0 -1px 3px rgba(40, 40, 40, 0.2);
37@@ -2163,6 +2163,7 @@
38 }
39 .openerp .oe_form header {
40 position: relative;
41+ overflow: hidden;
42 border-bottom: 1px solid #cacaca;
43 padding-left: 2px;
44 background-color: #ededed;
45@@ -2288,7 +2289,7 @@
46 }
47 .openerp .oe_form .oe_form_label_help[for] span, .openerp .oe_form .oe_form_label[for] span {
48 font-size: 80%;
49- color: darkGreen;
50+ color: darkgreen;
51 vertical-align: top;
52 position: relative;
53 top: -4px;
54
55=== modified file 'addons/web/static/src/css/base.sass'
56--- addons/web/static/src/css/base.sass 2014-02-04 15:50:46 +0000
57+++ addons/web/static/src/css/base.sass 2014-02-13 14:14:05 +0000
58@@ -1711,6 +1711,7 @@
59 // FormView.header {{{
60 .oe_form header
61 position: relative
62+ overflow: hidden
63 border-bottom: 1px solid #cacaca
64 padding-left: 2px
65 @include vertical-gradient(#fcfcfc, #dedede)
66
67=== modified file 'addons/web/static/src/js/view_form.js'
68--- addons/web/static/src/js/view_form.js 2014-02-06 10:24:09 +0000
69+++ addons/web/static/src/js/view_form.js 2014-02-13 14:14:05 +0000
70@@ -5389,9 +5389,6 @@
71 if (this.options.clickable) {
72 this.$el.on('click','li',this.on_click_stage);
73 }
74- if (this.$el.parent().is('header')) {
75- this.$el.after('<div class="oe_clear"/>');
76- }
77 this._super();
78 },
79 set_value: function(value_) {