Merge lp:~openerp-dev/openerp-web/7.0-opw-602858ReadonlyFieldsInEditableListview-msh into lp:openerp-web/7.0

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of readonly field not displayed in editable listview which creates issue with onchange result, result of onchange doesn't diplayed untill editable row is saved, the reason is we kept readonly field invisible in edition form and that's why that readonly field widget doesn't positioned as the place edition form and simple cell is displayed, onchange result calls set_value but value is set on hidden element which is not displayed on edition form.

We have this issues due to two layer, for readonly field we do not displays form fields from form layer instead we just show simple td with span.

Demo:- Add one readonly field in any editable one2many listview and get the value of that field from onchange of another field, you will see when you change the value of the field, readonly field is not affected with value returned by onchange, when we save the whole line at that time we get the value of onchange.

Removed this complication of two layersm instead displayed all form fields, even if it is readonly and cahnged css accordingly, also changd css for float, integer and handle widget as a specical case.

Thanks.

[lp:~openerp-dev/openerp-web/7.0-opw-602858ReadonlyFieldsInEditableListview-msh]

4163. By Launchpad Translations on behalf of openerp on 2014-03-25

Launchpad automatic translations update.

4164. By Denis Ledoux (OpenERP) on 2014-03-26

[FIX] web: on record reload (form & list view), use search_read instead of read, to check if the user can still read the record (security rules)

4165. By Denis Ledoux (OpenERP) on 2014-03-26

[REVERT] 4164 revid:<email address hidden>: this fix actually works in saas-3, but not in 7.0, as search_read method is not part of the orm

4166. By Martin Trigaux (OpenERP) on 2014-03-27

[IMP] cookies: when retrieving session cookie, catch eventual parsing errors and remove cookie if incorrect (opw 605648)

In case of unparsable cookie (modified, corrupted,...), openerp would not load and crash with white screen until expiration.
With the fix goes back to login screen.

4167. By Launchpad Translations on behalf of openerp on 2014-03-28

Launchpad automatic translations update.

4168. By Launchpad Translations on behalf of openerp on 2014-03-29

Launchpad automatic translations update.

4169. By Martin Trigaux (OpenERP) on 2014-04-07

[MERGE] [FIX] upload widget: avoid overflow making impossible to click on other buttons than the first one (opw 603125)

4170. By Denis Ledoux (OpenERP) on 2014-04-08

[IMP] web: select input on add record in list editable

4171. By Denis Ledoux (OpenERP) on 2014-04-09

[FIX] web: impossible to click on attach button, for many2many_binary

This fix is related to revision 4169 revid:<email address hidden>

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

Sorry but this still does not work. For instance go to "customer payment" view, add a line (where we have some readonly fields), you will get "Uncaught TypeError: Cannot read property '$input' of undefined".

Regards

review: Needs Fixing

[lp:~openerp-dev/openerp-web/7.0-opw-602858ReadonlyFieldsInEditableListview-msh]

4172. By Martin Trigaux (OpenERP) on 2014-04-14

[MERGE] [FIX] FormView: avoid multiple creations of the same line in o2m fields when the save action fails (e.g. forgot one required field)

This is done by removing the added action 'prepend_on_create' that can be present as many time as we pressed the save button

4173. By Launchpad Translations on behalf of openerp on 2014-04-15

Launchpad automatic translations update.

4174. By Denis Ledoux (OpenERP) on 2014-04-15

[FIX] web_kanban: show more button of kanban view behind the kanban cards on (ie9)

4175. By Denis Ledoux (OpenERP) on 2014-04-17

[FIX] web: double click on save button was trying to save the data two times if there is some latency

4176. By Denis Ledoux (OpenERP) on 2014-04-17

[FIX] web: double click on save button was trying to save the data two times if there is some latency, event target should be used instead of delegate target

4177. By Denis Ledoux (OpenERP) on 2014-04-17

[REVERT] web: 4174 revid:<email address hidden>, break the kanban drag and drop, which is far more important than the show more button wrongly displayed in ie.

4178. By Martin Trigaux (OpenERP) on 2014-04-18

[FIX] FieldMany2One: avoid error when saving changes in popup from a related fields (opw 606601)

4179. By Denis Ledoux (OpenERP) on 2014-04-22

[FIX] web: abitility to do exact id matching with child_of operator for searchs on many2one fields

4180. By Launchpad Translations on behalf of openerp on 2014-04-23

Launchpad automatic translations update.

4181. By Martin Trigaux (OpenERP) on 2014-04-25

[FIX] view: avoid propagation of context while executing an action

As the action could lead to unrelated model, keeping the defaults, groupby and ref do not make sense.
Backport of saas-2 revision 3872, 3891, 3892, 3893 and 3905

4182. By Launchpad Translations on behalf of openerp on 2014-05-03

Launchpad automatic translations update.

4183. By Launchpad Translations on behalf of openerp on 2014-05-04

Launchpad automatic translations update.

4184. By Launchpad Translations on behalf of openerp on 2014-05-06

Launchpad automatic translations update.

4185. By Launchpad Translations on behalf of openerp on 2014-05-11

Launchpad automatic translations update.

4186. By Mohammed Shekha(Open ERP) on 2014-05-12

[FIX]Web: Re-Fixed the issue of readonly field not displayed which creates issue with onchange result, result of onchange doesn't diplayed untill editable row is saved, the reason is we kept readonly field invisible in edition form and that's why that readonly field widget doesn't positioned as the place edition form and simple cell is displayed, onchange result calls set_value but value is set on hidden element which is not displayed on edition form, also considered some other scenarios like many2one throws after setting field to visible so checked if many2one field is effective_readonly, also span in current row should not be displayed in edition mode,also fixed the issues of form view which sets dimension even in readonly.

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello Martin,

Thanks for your review.

I have re-fixed this issue described in comment 1.

Thanks.

review: Needs Resubmitting

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2014-04-09 09:34:22 +0000
+++ addons/web/static/src/css/base.css	2014-05-12 05:39:08 +0000
@@ -8,7 +8,6 @@
   font-weight: normal;
   font-style: normal;
 }
-
 @font-face {
   font-family: "EntypoRegular";
   src: url("/web/static/src/font/entypo-webfont.eot") format("eot");
@@ -19,7 +18,6 @@
   font-weight: normal;
   font-style: normal;
 }
-
 .openerp {
   padding: 0;
   margin: 0;
@@ -1029,7 +1027,7 @@
   background-image: -moz-linear-gradient(top, #fc8787, maroon);
   background-image: -ms-linear-gradient(top, #fc8787, maroon);
   background-image: -o-linear-gradient(top, #fc8787, maroon);
-  background-image: linear-gradient(to bottom, #fc8787, #800000);
+  background-image: linear-gradient(to bottom, #fc8787, maroon);
 }
 .openerp .oe_topbar .oe_topbar_anonymous_login a {
   display: block;
@@ -1275,7 +1273,7 @@
   color: white;
   padding: 2px 4px;
   margin: 1px 6px 0 0;
-  border: 1px solid lightGray;
+  border: 1px solid lightgray;
   text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
   -moz-border-radius: 4px;
   -webkit-border-radius: 4px;
@@ -1307,7 +1305,7 @@
   transform: scale(1.1);
 }
 .openerp .oe_secondary_submenu .oe_active {
-  border-top: 1px solid lightGray;
+  border-top: 1px solid lightgray;
   border-bottom: 1px solid #dedede;
   text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
   -moz-box-shadow: inset 0 1px 3px rgba(0, 0, 0, 0.2), inset 0 -1px 3px rgba(40, 40, 40, 0.2);
@@ -2289,7 +2287,7 @@
 }
 .openerp .oe_form .oe_form_label_help[for] span, .openerp .oe_form .oe_form_label[for] span {
   font-size: 80%;
-  color: darkGreen;
+  color: darkgreen;
   vertical-align: top;
   position: relative;
   top: -4px;
@@ -2815,11 +2813,11 @@
 .openerp .oe_list_editable .oe_list_content td.oe_list_field_cell {
   padding: 4px 6px 3px;
 }
-.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell:not(.oe_readonly) {
+.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell {
   color: transparent;
   text-shadow: none;
 }
-.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell:not(.oe_readonly) * {
+.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell * {
   visibility: hidden;
 }
 .openerp .oe_list.oe_list_editable.oe_editing .oe_m2o_drop_down_button {
@@ -2835,6 +2833,25 @@
   min-width: 0;
   max-width: none;
 }
+.openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_list_field_handle {
+  font-size: 1px;
+  letter-spacing: -1px;
+  color: transparent;
+  text-shadow: none;
+  font-weight: normal;
+  letter-spacing: normal !important;
+  color: transparent;
+  margin-right: 7px;
+}
+.openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_list_field_handle:before {
+  font: 18px "entypoRegular";
+  content: "}";
+  color: #e0e0e0;
+}
+.openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_readonly {
+  padding: 4px 6px 3px;
+  text-align: left;
+}
 .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field input, .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field textarea {
   height: 27px;
   -moz-border-radius: 0;
@@ -2846,6 +2863,10 @@
 .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field input, .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field textarea, .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field select {
   min-width: 0;
 }
+.openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_form_field_float.oe_readonly, .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_form_view_integer.oe_readonly {
+  padding: 4px 6px 3px 0px;
+  text-align: right !important;
+}
 .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_form_field_float input, .openerp .oe_list.oe_list_editable.oe_editing .oe_form_field.oe_form_view_integer input {
   text-align: right;
   width: 100% !important;

=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass	2014-04-09 09:34:22 +0000
+++ addons/web/static/src/css/base.sass	2014-05-12 05:39:08 +0000
@@ -2218,7 +2218,7 @@
     .oe_list_editable .oe_list_content td.oe_list_field_cell
         padding: 4px 6px 3px
     .oe_list.oe_list_editable.oe_editing
-        .oe_edition .oe_list_field_cell:not(.oe_readonly)
+        .oe_edition .oe_list_field_cell
             *
                 visibility: hidden
             color: transparent
@@ -2230,6 +2230,14 @@
         .oe_input_icon
             margin-top: 5px
         .oe_form_field
+            &.oe_list_field_handle
+                @include text-to-entypo-icon("}",#E0E0E0,18px)
+                letter-spacing: normal !important
+                color: transparent
+                margin-right: 7px
+            &.oe_readonly
+                padding: 4px 6px 3px
+                text-align: left
             min-width: 0
             max-width: none
             input, textarea
@@ -2240,6 +2248,9 @@
             input, textarea, select
                 min-width: 0
             &.oe_form_field_float,&.oe_form_view_integer
+                &.oe_readonly
+                    padding: 4px 6px 3px 0px
+                    text-align: right !important
                 input
                     text-align: right
                     width: 100% !important

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2014-04-18 09:20:33 +0000
+++ addons/web/static/src/js/view_form.js	2014-05-12 05:39:08 +0000
@@ -2599,7 +2599,8 @@
     },
     set_dimensions: function (height, width) {
         this._super(height, width);
-        this.datewidget.$input.css('height', height);
+        if (!this.get("effective_readonly") && this.datewidget.$input)
+            this.datewidget.$input.css('height', height);
     }
 });
 
@@ -3394,7 +3395,8 @@
     },
     set_dimensions: function (height, width) {
         this._super(height, width);
-        this.$input.css('height', height);
+        if (!this.get("effective_readonly") && this.$input)
+            this.$input.css('height', height);
     }
 });
 

=== modified file 'addons/web/static/src/js/view_list_editable.js'
--- addons/web/static/src/js/view_list_editable.js	2014-04-08 12:01:41 +0000
+++ addons/web/static/src/js/view_list_editable.js	2014-05-12 05:39:08 +0000
@@ -283,9 +283,7 @@
             if (!this.editor.is_editing()) { return; }
             for(var i=0, len=this.fields_for_resize.length; i<len; ++i) {
                 var item = this.fields_for_resize[i];
-                if (!item.field.get('effective_invisible')) {
-                    this.resize_field(item.field, item.cell);
-                }
+                this.resize_field(item.field, item.cell);
             }
         },
         /**
@@ -304,6 +302,11 @@
                 at: 'left top',
                 of: $cell
             });
+            if (field.get('effective_readonly')) {
+                field.$el.addClass('oe_readonly');
+            }
+            if(field.widget == "handle")
+                field.$el.addClass('oe_list_field_handle');
         },
         /**
          * @return {jQuery.Deferred}
@@ -449,13 +452,10 @@
         setup_events: function () {
             var self = this;
             _.each(this.editor.form.fields, function(field, field_name) {
-                var set_invisible = function() {
-                    field.set({'force_invisible': field.get('effective_readonly')});
+                var set_readonly = function() {
+                    field.set({'readonly': field.get('effective_readonly')});
                 };
-                field.on("change:effective_readonly", self, set_invisible);
-                set_invisible();
-                field.on('change:effective_invisible', self, function () {
-                    if (field.get('effective_invisible')) { return; }
+                field.on("change:effective_readonly", self, function(){
                     var item = _(self.fields_for_resize).find(function (item) {
                         return item.field === field;
                     });
@@ -464,8 +464,8 @@
                             self.resize_field(item.field, item.cell);
                         }, 0);
                     }
-                     
                 });
+                set_readonly();
             });
 
             this.editor.$el.on('keyup keypress keydown', function (e) {