Merge lp:~openerp-dev/openerp-web/7.0-opw-602858-msh into lp:openerp-web/7.0

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of readonly field not displayed in editable listview which creates issue with onchange result, result of onchange doesn't diplayed untill editable row is saved, the reason is we kept readonly field invisible in edition form and that's why that readonly field widget doesn't positioned as the place edition form and simple cell is displayed, onchange result calls set_value but value is set on hidden element which is not displayed on edition form, also considered some other scenarios like many2one throws after setting field to visible so checked if many2one field is effective_readonly, also span in current row should not be displayed in edition mode.

Demo:- Add one readonly field in any editable one2many listview and get the value of that field from onchange of another field, you will see when you change the value of the field, readonly field is not affected with value returned by onchange, when we save the whole line at that time we get the value of onchange.

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hrllo,

Why do you change the css ? It does not seem to have any impact.
With this patch the on_change put the value in the top-left corner, it should be put at the right (or at least in the middle-left side, not top).

review: Needs Fixing

[Martin Trigaux (OpenERP) (mat-openerp)]

Also this is wrong to just remove the invisibility.
For instance go to a sale order, it will display the sequence number instead of the handle widget. Also this code was made to handle correctly the cases where a field goes from readonly to editable in a tree view (broken with your patch).

Regards

review: Needs Fixing

Unmerged revisions

4113. By Mohammed Shekha(OpenERP)<email address hidden> on 2014-01-15

[FIX]Web: Fixed the issue of readonly field not displayed which creates issue with onchange result, result of onchange doesn't diplayed untill editable row is saved, the reason is we kept readonly field invisible in edition form and that's why that readonly field widget doesn't positioned as the place edition form and simple cell is displayed, onchange result calls set_value but value is set on hidden element which is not displayed on edition form, also considered some other scenarios like many2one throws after setting field to visible so checked if many2one field is effective_readonly, also span in current row should not be displayed in edition mode.

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2014-01-20 16:35:54 +0000
+++ addons/web/static/src/css/base.css	2014-02-03 13:04:05 +0000
@@ -2801,11 +2801,11 @@
 .openerp .oe_list_editable .oe_list_content td.oe_list_field_cell {
   padding: 4px 6px 3px;
 }
-.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell:not(.oe_readonly) {
+.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell {
   color: transparent;
   text-shadow: none;
 }
-.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell:not(.oe_readonly) * {
+.openerp .oe_list.oe_list_editable.oe_editing .oe_edition .oe_list_field_cell * {
   visibility: hidden;
 }
 .openerp .oe_list.oe_list_editable.oe_editing .oe_m2o_drop_down_button {

=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass	2014-01-20 16:35:54 +0000
+++ addons/web/static/src/css/base.sass	2014-02-03 13:04:05 +0000
@@ -2207,7 +2207,7 @@
     .oe_list_editable .oe_list_content td.oe_list_field_cell
         padding: 4px 6px 3px
     .oe_list.oe_list_editable.oe_editing
-        .oe_edition .oe_list_field_cell:not(.oe_readonly)
+        .oe_edition .oe_list_field_cell
             *
                 visibility: hidden
             color: transparent

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2014-01-20 16:01:47 +0000
+++ addons/web/static/src/js/view_form.js	2014-02-03 13:04:05 +0000
@@ -3387,7 +3387,8 @@
     },
     set_dimensions: function (height, width) {
         this._super(height, width);
-        this.$input.css('height', height);
+        if (!this.get("effective_readonly") && this.$input)
+            this.$input.css('height', height);
     }
 });
 

=== modified file 'addons/web/static/src/js/view_list_editable.js'
--- addons/web/static/src/js/view_list_editable.js	2013-12-18 15:26:26 +0000
+++ addons/web/static/src/js/view_list_editable.js	2014-02-03 13:04:05 +0000
@@ -440,11 +440,6 @@
         setup_events: function () {
             var self = this;
             _.each(this.editor.form.fields, function(field, field_name) {
-                var set_invisible = function() {
-                    field.set({'force_invisible': field.get('effective_readonly')});
-                };
-                field.on("change:effective_readonly", self, set_invisible);
-                set_invisible();
                 field.on('change:effective_invisible', self, function () {
                     if (field.get('effective_invisible')) { return; }
                     var item = _(self.fields_for_resize).find(function (item) {