Merge lp:~openerp-dev/openerp-web/7.0-opw-599980-msh into lp:openerp-web/7.0

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of statubar doesn't call on_change.

Demo: Defined on_change attrs on any statusbar widget field and then click on that statusbar.

Result it will not call on_change method
Expected: It should call on_change and then set the value of on_change result and the statusbar should call recursive_save and reload_view.

For reference go through following bug:
https://bugs.launchpad.net/openerp-web/+bug/1175960

Also after setting value in field there is no need to call write explicitly because recursive_save will do the job of write, so removing explicit call of write.

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

Sorry but I wil lreject this as the bug is a feature request (we want to keep the current behaviour).
See the bug report for more details.

Regards

review: Disapprove

Unmerged revisions

4049. By Mohammed Shekha(OpenERP)<email address hidden> on 2013-10-29

[FIX]Web: Fixed the issue of statusbar, clicking on statusbar does not call on_change method.

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2013-10-10 09:11:25 +0000
+++ addons/web/static/src/js/view_form.js	2013-10-29 12:33:10 +0000
@@ -5452,17 +5452,17 @@
             }
         });
     },
+    set_value_selected: function(val) {
+        this.set({'value': val});
+    }, 
     on_click_stage: function (ev) {
         var self = this;
         var $li = $(ev.currentTarget);
         var val = parseInt($li.data("id"));
         if (val != self.get('value')) {
+            this.set_value_selected(val)
             this.view.recursive_save().done(function() {
-                var change = {};
-                change[self.name] = val;
-                self.view.dataset.write(self.view.datarecord.id, change).done(function() {
-                    self.view.reload();
-                });
+                self.view.reload();
             });
         }
     },