Merge lp:~openerp-dev/openerp-web/7.0-opw-599579-ado into lp:openerp-web/7.0

Proposed by Amit Dodiya (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-599579-ado
Merge into: lp:openerp-web/7.0
Diff against target: 14 lines (+2/-2)
1 file modified
addons/web/static/src/js/search.js (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-599579-ado
Reviewer Review Type Date Requested Status
Naresh(OpenERP) Pending
Review via email: mp+193399@code.launchpad.net

Description of the change

Hello,

[FIX] is_set and is_not_set gives trace-back & wrong result on text type field so change the value of this operator

Issue:
Error while searching on "Description" field of product with operator "is set" or "is not set".

Steps:
1). Open the product list
2). Add advance filter with description + is_set / is_not_set

This error is fixed from both side server & web-client following is the branch for server:
branch: lp:~openerp-dev/openobject-server/7.0-opw-599579-ado

To post a comment you must log in.

Unmerged revisions

4049. By Amit Dodiya (OpenERP)

[FIX] is_set and is_not_set gives traceback wrong result on text type field so change the operator of this operator

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/search.js'
2--- addons/web/static/src/js/search.js 2013-10-22 16:25:19 +0000
3+++ addons/web/static/src/js/search.js 2013-10-31 10:37:00 +0000
4@@ -2017,8 +2017,8 @@
5 },
6 get_domain: function (field, operator) {
7 switch (operator.value) {
8- case '∃': return this.make_domain(field.name, '!=', false);
9- case '∄': return this.make_domain(field.name, '=', false);
10+ case '∃': return this.make_domain(field.name, 'is not', null);
11+ case '∄': return this.make_domain(field.name, 'is', null);
12 default: return this.make_domain(
13 field.name, operator.value, this.get_value());
14 }