Merge lp:~openerp-dev/openerp-web/7.0-opw-594708-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Merged at revision: 4093
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-594708-msh
Merge into: lp:openerp-web/7.0
Diff against target: 23 lines (+4/-2)
1 file modified
addons/web/static/src/js/view_list.js (+4/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-594708-msh
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Approve
Xavier (Open ERP) Pending
Review via email: mp+173134@code.launchpad.net

Description of the change

Hello,

Fixed the issue of last element of grouped row removed instead of removing span and buttons.

Demo:- Open any list view and do grouping such that on grouped row we get pager, now just expand and collapse that row, the row grouped value(which is some of childrens) removed for last element.
For example goto Reporting -> Point of Sale -> Order Analysis -> Group on Sales Person only.
Now just expand(we will get pager on last element) and collapse the grouped row(removed last element).

Thanks.

To post a comment you must log in.
3994. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

3995. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

3996. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

3997. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

3998. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

3999. By Nicolas Vanhoren (OpenERP)

[FIX] problem with werkzeug 0.9.1 that makes the code crash when we generate a report

4000. By Nicolas Vanhoren (OpenERP)

[FIX] some more problems with werkzeug 0.9.1

4001. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4002. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4003. By Paramjit Singh Sahota <email address hidden>

[FIX] web_calendar: do not generate invalid domain if views does not specify a "date_stop" field

4004. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4005. By Nicolas Vanhoren (OpenERP)

[FIX] some crash in the view manager

4006. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4007. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4008. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4009. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4010. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4011. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4012. By Nicolas Vanhoren (OpenERP)

[FIX] remove last password saving feature

4013. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4014. By Martin Trigaux (OpenERP)

[FIX] vertical alignment of fields on firefox (opw #590181)

4015. By Martin Trigaux (OpenERP)

[MERGE] [FIX] reload form if button has option reload_on_button

4016. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4017. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4018. By Martin Trigaux (OpenERP)

[FIX] tree view: correct toggeling of hierarchic tree, correctly pass ids

4019. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4020. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4021. By Martin Trigaux (OpenERP)

[FIX] tree views: rename variable parent-id to avoid conflicts with record fields name (eg: account.account)

4022. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4023. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4024. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4025. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4026. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4027. By Martin Trigaux (OpenERP)

[MERGE] [FIX] pass context for 2many fields in views

4028. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4029. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4030. By Denis Ledoux (OpenERP)

[FIX]web base: when kanban view was setted after the tree view in the views sequence, the form view was located in the footer of the web page.

4031. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4032. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4033. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4034. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4035. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4036. By Xavier (Open ERP)

[FIX] null >= 0 is true...

4037. By Xavier (Open ERP)

[FIX] double-escaping of section labels in m2o completion

4038. By Nicolas Vanhoren (OpenERP)

[IMP] enabled sorting in o2m in list view

4039. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4040. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4041. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4042. By Denis Ledoux (OpenERP)

[FIX]web: filter name input for custom filters in search dropdown is now required

4043. By Denis Ledoux (OpenERP)

[FIX]web: test testing the customer filter save was wrong, was using wrong method text() instead of val() to set the filter name

4044. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4045. By xmo

[FIX] list view: serialize concurrent calls when loading files and ensure consistency of variables (prevent selection of items in list view lost, opw #599969)

4046. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4047. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4048. By Martin Trigaux (OpenERP)

[FIX] list: force to recompute the selection as closing group reset items and would lead to an incorrect count of ids (eg: not hidding sidebar when no item is selected) (opw #599969)

4049. By Christophe Simonis (OpenERP)

[FIX] web: allow grouping on fields not present in list view
[FIX] web,web_kanban: read_group: ensure read grouping fields

4050. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4051. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4052. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4053. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4054. By Christophe Simonis (OpenERP)

[FIX] web_kanban: correct design of vertical title on IE

4055. By Christophe Simonis (OpenERP)

[FIX] web: instance.web.DataSetSearch.get_domain() returns the domain.

4056. By Mohammed Shekha(OpenERP)<email address hidden>

[FIX]Re-fixed the issue of pager on group by view, last element of the row removes total value.

Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello,

Also fixed the issue of aggregate value removed when group row has only one page and it is expanded.

Demo: Goto any list view, do grouping on any fiels so that it returns less then 80 records per group, as there is only one page so there is no need of pager so we removed 'td.oe_list_group_pagination'(we make whole td empty) so it will also remove aggregate amount value also.

We should only remove button and span not all td value.

Thanks.

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Thanks for the patch, merged in web 7.0

revno: 4093 [merge]
revision-id: <email address hidden>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list.js'
2--- addons/web/static/src/js/view_list.js 2013-10-30 18:02:42 +0000
3+++ addons/web/static/src/js/view_list.js 2013-11-06 13:50:16 +0000
4@@ -1284,7 +1284,8 @@
5 }
6 },
7 close: function () {
8- this.$row.children().last().empty();
9+ this.$row.children().last().find('button').remove();
10+ this.$row.children().last().find('span').remove();
11 this.records.reset();
12 },
13 /**
14@@ -1456,7 +1457,8 @@
15 } else {
16 if (dataset.size() == records.length) {
17 // only one page
18- self.$row.find('td.oe_list_group_pagination').empty();
19+ self.$row.find('td.oe_list_group_pagination').find('button').remove();
20+ self.$row.find('td.oe_list_group_pagination').find('span').remove();
21 } else {
22 var pages = Math.ceil(dataset.size() / limit);
23 self.$row