Merge lp:~openerp-dev/openerp-web/7.0-opw-593892-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Merged at revision: 4152
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-593892-msh
Merge into: lp:openerp-web/7.0
Diff against target: 36 lines (+7/-7)
1 file modified
addons/web/static/src/js/data_export.js (+7/-7)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-593892-msh
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Approve
Xavier (Open ERP) Pending
Review via email: mp+170238@code.launchpad.net

Description of the change

Hello,

Fixed the issue of save listed fields in export, fields disappears after saving field's list.

Demo:- Select any record of any list view and Export -> selects fields -> Save the field list.
Issue 1. List Disappear
Issue 2. Saved Field List selection doesn't rendered.
Issue 3. After deletion of saved list, that saved field list should be removed.

The first issue is that the callback written is not going to call so put it in then method, also rpc returns response result so no need to again do export_list_id.result.

Fixed all described stuff.

Thanks.

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Thanks for the patch, merged in 7.0

revno: 4152 [merge]
revision-id: <email address hidden>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/data_export.js'
2--- addons/web/static/src/js/data_export.js 2013-05-30 10:04:20 +0000
3+++ addons/web/static/src/js/data_export.js 2013-06-19 04:53:26 +0000
4@@ -101,6 +101,7 @@
5 if (select_exp.val()) {
6 self.exports.unlink([parseInt(select_exp.val(), 10)]);
7 select_exp.remove();
8+ self.$el.find("#fields_list option").remove();
9 if (self.$el.find('#saved_export_list option').length <= 1) {
10 self.$el.find('#ExistsExportList').hide();
11 }
12@@ -148,18 +149,17 @@
13 export_fields: _(fields).map(function (field) {
14 return [0, 0, {name: field}];
15 })
16- }, function (export_list_id) {
17- if (!export_list_id.result) {
18+ }).then(function (export_list_id) {
19+ if (!export_list_id) {
20 return;
21 }
22+ if (!self.$el.find("#saved_export_list").length || self.$el.find("#saved_export_list").is(":hidden")) {
23+ self.show_exports_list();
24+ }
25 self.$el.find("#saved_export_list").append(
26- new Option(value, export_list_id.result));
27- if (self.$el.find("#saved_export_list").is(":hidden")) {
28- self.show_exports_list();
29- }
30+ new Option(value, export_list_id));
31 });
32 this.on_show_save_list();
33- this.$el.find("#fields_list option").remove();
34 },
35 on_click: function(id, record) {
36 var self = this;