Merge lp:~openerp-dev/openerp-web/7.0-opw-591038-cpa into lp:openerp-web/7.0

Proposed by Chirag Patel (OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-591038-cpa
Merge into: lp:openerp-web/7.0
Diff against target: 15 lines (+2/-2)
1 file modified
addons/web/static/src/js/view_list.js (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-591038-cpa
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+158605@code.launchpad.net

Description of the change

Hello,

Record not expand when groupby on float field.

Demo:
1) Add following filter in "Quotation" search view.
   <filter string="My total" icon="terp-go-month" context="{'group_by':'amount_total'}"/>
2) Groupby on this filter.
3) Try to expand groupby record which have more then 1 record.

Observed: Records not expand in list view.

Required branch for server
lp:~openerp-dev/openobject-server/7.0-opw-591038-cpa

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

See comment on server branch.

review: Disapprove

Unmerged revisions

3892. By Chirag Patel (OpenERP)

[FIX] Fixed groupby on float field and expand groupby record.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list.js'
2--- addons/web/static/src/js/view_list.js 2013-03-22 16:23:10 +0000
3+++ addons/web/static/src/js/view_list.js 2013-04-12 13:08:54 +0000
4@@ -1383,9 +1383,9 @@
5 .each(function (column) {
6 if (column.meta) {
7 // do not do anything
8- } else if (column.id in group.aggregates) {
9+ } else if (column.id+"_header" in group.aggregates) {
10 var r = {};
11- r[column.id] = {value: group.aggregates[column.id]};
12+ r[column.id] = {value: group.aggregates[column.id+"_header"]};
13 $('<td class="oe_number">')
14 .html(column.format(r, {process_modifiers: false}))
15 .appendTo($row);