Merge lp:~openerp-dev/openerp-web/7.0-opw-590268-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Merge reported by: Mohammed Shekha(Open ERP)
Merged at revision: not available
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-590268-msh
Merge into: lp:openerp-web/7.0
Diff against target: 13 lines (+3/-0)
1 file modified
addons/web_view_editor/static/src/js/view_editor.js (+3/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-590268-msh
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+154698@code.launchpad.net

Description of the change

Hello,

Fixed the issue of view_editor, it throws error if there is data tag added in view and when you edit the field.

Demo:- Start Debug moce, Settings -> Technical -> Configuration Wizards -> Launch Configure Accounting Data wizard and then open Manage view -> Edit that view and change field detail and update, you will face error, reason is that in load_xml document object passed instead of string, so converted dom object to string and then passed.

Thanks.

To post a comment you must log in.
Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello,

It has already been merged in with revision 3858.

Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_view_editor/static/src/js/view_editor.js'
2--- addons/web_view_editor/static/src/js/view_editor.js 2012-11-29 14:01:09 +0000
3+++ addons/web_view_editor/static/src/js/view_editor.js 2013-03-21 13:39:21 +0000
4@@ -642,6 +642,9 @@
5 insert = _.intersection(_.flatten(temp_obj.att_list),_.uniq(check_list));
6 if (insert.length == _.uniq(check_list).length ) {return xml_child;}
7 });
8+ if (typeof arch.arch != "string"){
9+ arch.arch = QWeb.tools.xml_node_to_string(arch.arch);
10+ }
11 xml_arch = QWeb.load_xml(arch.arch);
12 }
13 return self.do_save_xml(xml_arch.documentElement, obj[0].child_id[0],obj[0].child_id, move_direct, update_values,arch);