Merge lp:~openerp-dev/openerp-web/7.0-opw-589782-cbi into lp:openerp-web/7.0

[Chris Biersbach (OpenERP)]

[Chris Biersbach (OpenERP) (cbi-openerp)]

The issue: A maximum of 7 entries appear in o2m fields (it should be 8)

The reason: The limit was set to 7, the search was done with limit+1 (8).
The results were then sliced (0 to 7 NOT included) -> 7 results

The fix: I changed the limit o 8, the search to limit and now the slice actually behaves the way we want (8 entries)

[Csaba TOTH (tsabi)]

I tested this patch, and this eliminitaes the "Search more..." action to show up in the list!

review: Disapprove

[Xavier (Open ERP) (xmo-deactivatedaccount)]

`limit + 1` is specifically to get one more record if there is, so `Search More` can be displayed if there are more than `this.limit` records in database. Otherwise can not know if there are more than this.limit records in database without second request.

To get 8 records, should just set limit to 8, not change limit in name_search.

review: Needs Fixing

Unmerged revisions

3840. By Chris Biersbach (OpenERP) on 2013-03-13

[FIX] web: I corrected the limit in the CompletionFieldMixin to 8 instead of 7 so that actually 8 entries appear (instead of 7). This was caused by an incorrect use of the slice method, which does not include the upper bound.

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2013-03-13 10:17:56 +0000
+++ addons/web/static/src/js/view_form.js	2013-03-13 14:17:08 +0000
@@ -2841,7 +2841,7 @@
  */
 instance.web.form.CompletionFieldMixin = {
     init: function() {
-        this.limit = 7;
+        this.limit = 8;
         this.orderer = new instance.web.DropMisordered();
     },
     /**
@@ -2856,7 +2856,7 @@
 
         return this.orderer.add(dataset.name_search(
                 search_val, new instance.web.CompoundDomain(self.build_domain(), [["id", "not in", blacklist]]),
-                'ilike', this.limit + 1, self.build_context())).then(function(data) {
+                'ilike', this.limit, self.build_context())).then(function(data) {
             self.last_search = data;
             // possible selections for the m2o
             var values = _.map(data, function(x) {