Merge lp:~openerp-dev/openerp-web/7.0-opw-587373-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-587373-msh
Merge into: lp:openerp-web/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/xml/base.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-587373-msh
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+152126@code.launchpad.net

Description of the change

Hello,

Fixed the issue of company logo image correct company logo not loaded initially after login, as firefox reads cached image for same uri where this is not the cache with Chrome.

Demo:- Change the image of company, now logout and again login(In Firefox only), initially image of company logo which is changed will not come, if you refresh the page you will get the proper company logo image
(strange issue).

After digging inside this issue I found the soltion to put random query string or put datetime in query string, this will reloads the image.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

This should be fixed by providing the right caching directives when returning the company logo image.

review: Disapprove

Unmerged revisions

3819. By Mohammed Shekha<email address hidden>

[FIX]Fixed the issue of company logo image correct company logo not loaded initially after login, as firefox reads from cached image for same uri.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/xml/base.xml'
2--- addons/web/static/src/xml/base.xml 2013-03-06 15:13:06 +0000
3+++ addons/web/static/src/xml/base.xml 2013-03-07 09:01:35 +0000
4@@ -442,7 +442,7 @@
5 <t t-set="debug" t-value="__debug__ ? '&amp;debug' : ''"/>
6 <a class="oe_logo" t-attf-href="/?ts=#{Date.now()}#{debug}">
7 <span class="oe_logo_edit">Edit Company data</span>
8- <img t-att-src='widget.session.url("/web/binary/company_logo")'/>
9+ <img t-att-src='widget.session.url("/web/binary/company_logo/?#{Date.now()}")'/>
10 </a>
11 <div class="oe_secondary_menus_container"/>
12 <div class="oe_footer">