Merge lp:~openerp-dev/openerp-web/7.0-opw-586827-cpa into lp:openerp-web/7.0

Proposed by Chirag Patel (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-586827-cpa
Merge into: lp:openerp-web/7.0
Diff against target: 18 lines (+1/-7)
1 file modified
addons/web/static/src/js/view_list.js (+1/-7)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-586827-cpa
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+152391@code.launchpad.net

Description of the change

Hello,

Dataset index set null when list view have no records.

Demo: Accounting > Journal Entries > Journal Items
1) Create a Journal Items.
2) Change the Period which has no record.
3) Open form view.

Observed: TypeError: %d format: a number is required, not NoneType

To post a comment you must log in.

Unmerged revisions

3826. By Chirag Patel (OpenERP)

[FIX] Dataset index set null when list view have no records.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list.js'
2--- addons/web/static/src/js/view_list.js 2013-02-27 21:25:07 +0000
3+++ addons/web/static/src/js/view_list.js 2013-03-08 12:42:24 +0000
4@@ -503,13 +503,7 @@
5 var reloaded = $.Deferred();
6 this.$el.find('.oe_list_content').append(
7 this.groups.render(function () {
8- if (self.dataset.index == null) {
9- var has_one = false;
10- self.records.each(function () { has_one = true; });
11- if (has_one) {
12- self.dataset.index = 0;
13- }
14- }
15+ self.dataset.index = !self.records.length ? null : 0;
16 self.compute_aggregates();
17 reloaded.resolve();
18 }));