Merge lp:~openerp-dev/openerp-web/7.0-opw-584668-cpa into lp:openerp-web/7.0

[Chirag Patel (OpenERP)]

Hello,

Reproduce Issue: check the related bug #1101070 description.

Thanks

[Olivier Dony (Odoo) (odo-openerp)]

It seems that the bug was fixed by revision 3849 of openerp-web 7.0, related to bug 1091204.
Please provide more information if the problem is not solved completely. Thanks!

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I'm facing a very similar bug to lp:1088842 and this patch does fix the issue, which occurs even with revision 3849 of openerp-web.

To reproduce the issue :

1. create two models, testmodel and testmodel.line each with a name attribute
2. add a line_ids one2many relation to testmodel with the corresponding many2one relation in testmodel.line
3. add a function field to testmodel.line defined as:

class testmodel_line(orm.Model):
    def _fnc_reproduce(self, cr, uid, ids, field_name, arg, context=None):
        if context is None:
            context = {}
        assert 'new_key' in context
        return context['new_key']

    _columns = {'reproduce': fields.function(_fnc_reproduce, type='char', method=True, string='Reproduce bug')}

4. define a view for testmodel as:

    <record id="testmodel_form" model="ir.ui.view">
      <field name="name">testmodel form</field>
      <field name="model">testmodel</field>
      <field name="arch" type="xml">
        <form version="7.0" string="Test Model">
        <sheet>
          <group col="2">
            <field name="name">
            <field name='line_ids' context="{'new_key': 'new key value'}">
              <tree version="7.0" string="Area information" editable="bottom">
                <field name="name"/>
                <field name="reproduce"/>
              </tree>
            </field>
          </group>
        </sheet>
       </form>
      </field>
    </record>

Display the form view, create an entry, you should get a crash because of the lack of the key in the context passed to the function field.

BTW this is very close to the description of lp:1101070, which leads me to think that this bug is in fact different from lp:1091204.

I'm about to prepare a MP for OCB.

review: Approve (code review, test)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

OTOH, this branch breaks stuff: with the branch applied, I get errors when displaying the form view of res.partner :

in:

                        <field name="parent_id"
                            placeholder="Company"
                            domain="[('is_company', '=', True)]" context="{'default_is_company': True, 'default_supplier': supplier}"
                            attrs="{'invisible': [('is_company','=', True),('parent_id', '=', False)]}"
                            on_change="onchange_address(use_parent_address, parent_id)"/>

the evaluation of the context in javascript fails because supplier is not defined.

review: Needs Fixing (code review, test)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

reported https://bugs.launchpad.net/openerp-web/+bug/1217374 with everything needed to reproduce the issues.

Unmerged revisions

3730. By Chirag Patel (OpenERP) on 2013-01-28

[FIX] Fixed o2m or m2m in the form definition does not pass the context to the function fields.

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2013-01-24 14:40:18 +0000
+++ addons/web/static/src/js/view_form.js	2013-01-29 13:16:33 +0000
@@ -3360,7 +3360,7 @@
         this.form_last_update = $.Deferred();
         this.init_form_last_update = this.form_last_update;
         this.is_started = false;
-        this.dataset = new instance.web.form.One2ManyDataSet(this, this.field.relation);
+        this.dataset = new instance.web.form.One2ManyDataSet(this, this.field.relation, this.build_context());
         this.dataset.o2m = this;
         this.dataset.parent_view = this.view;
         this.dataset.child_name = this.name;
@@ -4108,7 +4108,7 @@
     init: function(field_manager, node) {
         this._super(field_manager, node);
         this.is_loaded = $.Deferred();
-        this.dataset = new instance.web.form.Many2ManyDataSet(this, this.field.relation);
+        this.dataset = new instance.web.form.Many2ManyDataSet(this, this.field.relation, this.build_context());
         this.dataset.m2m = this;
         var self = this;
         this.dataset.on('unlink', self, function(ids) {