Merge lp:~openerp-dev/openerp-web/7.0-opw-576425-port-ggh into lp:openerp-web/7.0

Proposed by Farid Ghanchi
Status: Rejected
Rejected by: Christophe Matthieu (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-576425-port-ggh
Merge into: lp:openerp-web/7.0
Diff against target: 25 lines (+2/-2)
2 files modified
addons/web/static/src/css/base.css (+1/-1)
addons/web/static/src/css/base.sass (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-576425-port-ggh
Reviewer Review Type Date Requested Status
Christophe Matthieu (OpenERP) (community) Disapprove
Review via email: mp+144231@code.launchpad.net

Description of the change

Hello,

In Firefox:

1. Setting => Technical => Email =>Emails. Open or create any record.
2. Open Attachment tab. Click on Add Button => Create new attachment.
3. Select any file and then click on Save As button.

when we click on Save As or Clear then also file selection dialog is opened, instead of it should ask for file save or clear file...

> *oe_form_binary_file*
> *oe_hidden_input_file* class is position:absolute chrome is work fine but in FF is set width in all three button respectivly so we set left property auto so issue had solved...

Thanks...
GGH

To post a comment you must log in.
Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Hi,
This fix don't work for attachment field of mail full composer.

review: Disapprove

Unmerged revisions

3709. By Farid Ghanchi

[Fix] Fixed the issue of email attachment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2013-01-09 13:18:48 +0000
3+++ addons/web/static/src/css/base.css 2013-01-22 07:10:26 +0000
4@@ -2444,7 +2444,7 @@
5 font-size: 12px;
6 position: absolute;
7 top: 1px;
8- left: 0;
9+ left: auto;
10 right: 0;
11 opacity: 0;
12 filter: alpha(opacity=0);
13
14=== modified file 'addons/web/static/src/css/base.sass'
15--- addons/web/static/src/css/base.sass 2013-01-09 13:18:48 +0000
16+++ addons/web/static/src/css/base.sass 2013-01-22 07:10:26 +0000
17@@ -1945,7 +1945,7 @@
18 font-size: 12px
19 position: absolute
20 top: 1px
21- left: 0
22+ left: auto
23 right: 0
24 opacity: 0
25 filter: alpha(opacity = 0)