Merge lp:~openerp-dev/openerp-web/7.0-kanban-folded-chm into lp:openerp-web/7.0

Proposed by Thibault Delavallée (OpenERP)
Status: Merged
Merged at revision: 3732
Proposed branch: lp:~openerp-dev/openerp-web/7.0-kanban-folded-chm
Merge into: lp:openerp-web/7.0
Diff against target: 159 lines (+44/-17)
3 files modified
addons/web_kanban/static/src/css/kanban.css (+15/-4)
addons/web_kanban/static/src/css/kanban.sass (+12/-3)
addons/web_kanban/static/src/xml/web_kanban.xml (+17/-10)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-kanban-folded-chm
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+145591@code.launchpad.net

Description of the change

[FIX] [IMP] kanban view: number of items in a column is now also displayed for folded columns. Indeed, using custom filters, it can be interesting to know whether there are items in the folded column. This branch also solves some CSS issues related to kanban view and re-indent some code.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/css/kanban.css'
2--- addons/web_kanban/static/src/css/kanban.css 2013-01-09 09:44:51 +0000
3+++ addons/web_kanban/static/src/css/kanban.css 2013-01-30 12:32:23 +0000
4@@ -92,12 +92,21 @@
5 overflow: hidden;
6 text-overflow: ellipsis;
7 }
8-.openerp .oe_kanban_view .oe_kanban_group_title .oe_kanban_group_length {
9+.openerp .oe_kanban_view .oe_kanban_group_length {
10+ text-align: center;
11+ display: none;
12+}
13+.openerp .oe_kanban_view .oe_kanban_group_length .oe_tag {
14+ position: relative;
15+ top: +8px;
16+ font-weight: bold;
17+}
18+.openerp .oe_kanban_view .oe_fold_column .oe_kanban_group_length {
19 position: absolute;
20 top: -1px;
21 right: -14px;
22- text-align: center;
23 float: right;
24+ display: block;
25 }
26 .openerp .oe_kanban_view .oe_kanban_header:hover .oe_kanban_group_length {
27 display: none;
28@@ -141,7 +150,8 @@
29 .openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_group_title, .openerp .oe_kanban_view .oe_kanban_group_folded.oe_kanban_column *, .openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_aggregates, .openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_add {
30 display: none;
31 }
32-.openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_group_title_vertical {
33+.openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_group_title_vertical,
34+.openerp .oe_kanban_view .oe_kanban_group_folded .oe_kanban_group_length {
35 display: block;
36 }
37 .openerp .oe_kanban_view .oe_kanban_group_folded .oe_dropdown_kanban {
38@@ -163,7 +173,7 @@
39 display: none;
40 position: relative;
41 opacity: 0.75;
42- top: 20px;
43+ top: 26px;
44 }
45 .openerp .oe_kanban_view .oe_kanban_add, .openerp .oe_kanban_view .oe_kanban_header .oe_dropdown_toggle {
46 margin-left: 4px;
47@@ -175,6 +185,7 @@
48 }
49 .openerp .oe_kanban_view .oe_kanban_header .oe_dropdown_toggle {
50 top: -2px;
51+ height: 14px;
52 }
53 .openerp .oe_kanban_view .oe_kanban_card, .openerp .oe_kanban_view .oe_dropdown_toggle {
54 cursor: pointer;
55
56=== modified file 'addons/web_kanban/static/src/css/kanban.sass'
57--- addons/web_kanban/static/src/css/kanban.sass 2013-01-09 09:44:51 +0000
58+++ addons/web_kanban/static/src/css/kanban.sass 2013-01-30 12:32:23 +0000
59@@ -54,6 +54,13 @@
60 &.oe_kanban_grouped .oe_kanban_dummy_cell
61 background: url(/web/static/src/img/form_sheetbg.png)
62 width: 100%
63+ .oe_kanban_group_length
64+ text-align: center
65+ display: none
66+ .oe_tag
67+ position: relative
68+ top: +8px
69+ font-weight: bold
70 .ui-sortable-placeholder
71 border: 1px solid rgba(0,0,0,0.1)
72 visibility: visible !important
73@@ -118,12 +125,13 @@
74 white-space: nowrap
75 overflow: hidden
76 text-overflow: ellipsis
77+ .oe_fold_column
78 .oe_kanban_group_length
79 position: absolute
80 top: -1px
81 right: -14px
82- text-align: center
83 float: right
84+ display: block
85 &.oe_kanban_grouped
86 .oe_kanban_column, .oe_kanban_group_header
87 width: 185px
88@@ -159,7 +167,7 @@
89 .oe_kanban_group_folded
90 .oe_kanban_group_title, &.oe_kanban_column *, .oe_kanban_aggregates, .oe_kanban_add
91 display: none
92- .oe_kanban_group_title_vertical
93+ .oe_kanban_group_title_vertical, .oe_kanban_group_length
94 display: block
95 .oe_dropdown_kanban
96 left: -5px
97@@ -178,7 +186,7 @@
98 display: none
99 position: relative
100 opacity: 0.75
101- top: 20px
102+ top: 26px
103 // }}}
104 // KanbanQuickCreate {{{
105 .oe_kanban_add, .oe_kanban_header .oe_dropdown_toggle
106@@ -189,6 +197,7 @@
107 top: -8px
108 .oe_kanban_header .oe_dropdown_toggle
109 top: -2px
110+ height: 14px;
111 .oe_kanban_card, .oe_dropdown_toggle
112 cursor: pointer
113 display: inline-block
114
115=== modified file 'addons/web_kanban/static/src/xml/web_kanban.xml'
116--- addons/web_kanban/static/src/xml/web_kanban.xml 2013-01-09 09:44:51 +0000
117+++ addons/web_kanban/static/src/xml/web_kanban.xml 2013-01-30 12:32:23 +0000
118@@ -34,16 +34,21 @@
119 <t t-if="widget.view._is_quick_create_enabled()">
120 <div class="oe_kanban_add oe_e" title="Quick create">]</div>
121 </t>
122- <div class="oe_dropdown_toggle oe_dropdown_kanban">
123- <span class="oe_e">í</span>
124- <ul class="oe_dropdown_menu oe_kanban_group_dropdown">
125- <li><a data-action="toggle_fold" href="#">Fold</a></li>
126- <t t-if="widget.view.grouped_by_m2o and widget.value">
127- <li><a data-action="edit" href="#">Edit</a></li>
128- <li><a data-action="delete" href="#">Delete</a></li>
129- </t>
130- </ul>
131+ <div class="oe_dropdown_toggle oe_dropdown_kanban">
132+ <div class="oe_kanban_group_length">
133+ <span class="oe_tag">
134+ <t t-if="widget.group.get('length') &gt; 99"> 99+ </t><t t-if="widget.group.get('length') &lt;= 99"> <t t-esc="widget.group.get('length')"/> </t>
135+ </span>
136 </div>
137+ <span class="oe_e">í</span>
138+ <ul class="oe_dropdown_menu oe_kanban_group_dropdown">
139+ <li><a data-action="toggle_fold" href="#">Fold</a></li>
140+ <t t-if="widget.view.grouped_by_m2o and widget.value">
141+ <li><a data-action="edit" href="#">Edit</a></li>
142+ <li><a data-action="delete" href="#">Delete</a></li>
143+ </t>
144+ </ul>
145+ </div>
146 <div class="oe_fold_column">
147 <div t-attf-class="oe_kanban_group_title #{widget.undefined_title ? 'oe_kanban_group_title_undefined' : ''}">
148 <div class="oe_kanban_group_length oe_tag">
149@@ -57,7 +62,9 @@
150 </li>
151 </ul>
152 </div>
153- <span t-if="widget.title" class="oe_kanban_group_title_vertical"><t t-esc="widget.title"/></span>
154+ <span t-if="widget.title" class="oe_kanban_group_title_vertical">
155+ <t t-esc="widget.title"/>
156+ </span>
157 </div>
158 </t>
159 <t t-if="! widget.view.group_by &amp;&amp; widget.view._is_quick_create_enabled()">