Merge lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth
Merge into: lp:openerp-web/7.0
Diff against target: 29 lines (+8/-0)
2 files modified
addons/web/static/src/css/base.css (+4/-0)
addons/web/static/src/css/base.sass (+4/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Needs Fixing
Review via email: mp+155940@code.launchpad.net

Description of the change

Hello,

      In the search box, when you do a advanced filter, the or seems clickable (hand cursor) but it is not, it is confusing i would change into "and" when clicking on it
The 'or' should not be clickable.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Change is overly complex, why not just remove `cursor` on `.openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced li` and then set `cursor:default` on `.openerp .oe_searchview .oe_searchview_drawer` (to offset `cursor:text` set on `.oe_searchview`)?

review: Needs Fixing
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Unmerged revisions

3868. By Bhumi Thakkar (Open ERP)

[IMP] Set cursor on or in advance search.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2013-03-21 16:47:41 +0000
3+++ addons/web/static/src/css/base.css 2013-03-28 12:03:33 +0000
4@@ -1970,6 +1970,10 @@
5 .openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced .searchview_extended_prop_or {
6 opacity: 0.5;
7 margin-left: -14px;
8+ cursor: cell;
9+ position: absolute;
10+ width: 16px;
11+ top: 5px;
12 }
13 .openerp .oe_searchview .oe_searchview_drawer .oe_opened h4:before {
14 content: "▾ ";
15
16=== modified file 'addons/web/static/src/css/base.sass'
17--- addons/web/static/src/css/base.sass 2013-03-21 16:47:41 +0000
18+++ addons/web/static/src/css/base.sass 2013-03-28 12:03:33 +0000
19@@ -1564,6 +1564,10 @@
20 .searchview_extended_prop_or
21 opacity: 0.5
22 margin-left: -14px
23+ cursor: cell
24+ position: absolute
25+ width: 16px
26+ top: 5px
27 .oe_opened
28 h4:before
29 content: "▾ "