Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-dev/openerp-web/7.0-imp-description-fka into lp:openerp-web/7.0

  1. 7.0-imp-description-fka
  2. Merge into 7.0
Proposed by Foram Katharotiya (OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-imp-description-fka
Merge into: lp:openerp-web/7.0
Diff against target: 13 lines (+1/-2)
1 file modified
addons/web/static/src/js/view_form.js (+1/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-imp-description-fka
Reviewer Review Type Date Requested Status
Xavier (Open ERP) Pending
Review via email: mp+153056@code.launchpad.net

This proposal supersedes a proposal from 2013-03-08.

Description of the change

Hello,

 - Fix the issue of False is returned when saving data in discription field even it's stay in empty.
   I have improved code as per your suggestion.

Thanks,
FKA.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote : Posted in a previous version of this proposal

What was a generic problem? Could you explain the issue this intends to fix?

review: Needs Information
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote : Posted in a previous version of this proposal

It looks like it's related to this task:
  https://openerp.my.openerp.com/#id=5201&view_type=form&model=project.task

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote : Posted in a previous version of this proposal

Looks like it.

This proposal completely removes all display of all text fields in "readonly" mode. Even when there is content in the field.

review: Disapprove
lp:~openerp-dev/openerp-web/7.0-imp-description-fka updated
3829. By Foram Katharotiya (OpenERP)

[MERGE] with 7.0

3830. By Foram Katharotiya (OpenERP)

[IMP] improve code

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Seems to have been fixed separately in <email address hidden>

Unmerged revisions

3830. By Foram Katharotiya (OpenERP)

[IMP] improve code

3829. By Foram Katharotiya (OpenERP)

[MERGE] with 7.0

3828. By Foram Katharotiya (OpenERP)

[IMP] fix the issue of showing False value in discription

3827. By Foram Katharotiya (OpenERP)

[MERGE] with 7.0

3826. By Foram Katharotiya (OpenERP)

[IMP] set empty description fields

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2013-03-12 17:05:15 +0000
3+++ addons/web/static/src/js/view_form.js 2013-03-13 06:48:20 +0000
4@@ -2602,8 +2602,7 @@
5 this.$textarea.trigger("autosize");
6 }
7 } else {
8- var txt = this.get("value");
9- this.$(".oe_form_text_content").text(txt);
10+ this.$(".oe_form_text_content").text(this.get("value") || '');
11 }
12 },
13 is_syntax_valid: function() {