Merge lp:~openerp-dev/openerp-web/7.0-fix-needaction-reload-chm into lp:openerp-web/7.0

Proposed by Christophe Matthieu (OpenERP)
Status: Merged
Merged at revision: 3920
Proposed branch: lp:~openerp-dev/openerp-web/7.0-fix-needaction-reload-chm
Merge into: lp:openerp-web/7.0
Diff against target: 14 lines (+2/-2)
1 file modified
addons/web/static/src/js/views.js (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-fix-needaction-reload-chm
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+163499@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Uncaught TypeError: Cannot call method 'do_reload_needaction' of undefined

To face regression you can go to Stock -> Incoming Shipment -> open form view and in one2many of stock move click on 'Put in current pack' this will raise error, or you can put any kind of object button in one2many anywhere and click on that object button will throw error.

3920. By Christophe Matthieu (OpenERP)

[FIX] needaction: issue 592134 'Uncaught TypeError: Cannot call method 'do_reload_needaction' of undefined'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/views.js'
2--- addons/web/static/src/js/views.js 2013-04-17 13:34:38 +0000
3+++ addons/web/static/src/js/views.js 2013-05-13 11:25:29 +0000
4@@ -1369,8 +1369,8 @@
5 }
6 args.push(context);
7 return dataset.call_button(action_data.name, args).then(handler).then(function () {
8- if (self.ViewManager.ActionManager) {
9- self.ViewManager.ActionManager.__parentedParent.menu.do_reload_needaction();
10+ if (instance.webclient) {
11+ instance.webclient.menu.do_reload_needaction();
12 }
13 });
14 } else if (action_data.type=="action") {