Merge lp:~openerp-dev/openerp-web/7.0-bug-1182101-darshan into lp:openerp-web/7.0

[Darshan Kalola(OpenERP)]

Hello,

             I have fixed the issue of Journal entry: Cannot read property 'id' of null and Object can not be converted to JSON

Thanks
Darshan

[Lorenzo Battistini (elbati)]

This works for me

[Lara (Therp) (lfreeke)]

I tested the fix and it works

review: Approve (testing)

[Xavier (Open ERP) (xmo-deactivatedaccount)]

What is the justification for randomly converting completely arbitrary objects?

review: Disapprove

[hiren (hiren-6)]

Any update on this? It affects us too, and is pretty bad since it breaks on what we consider core functionality for openerp.

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello Xavier,

I think darshan has just backported the fix from trunk revision 3547.

Would you please go through this revision, he has converted object for one2many field in context and domain.

Thanks.

[Dave Burkholder (akxws32zf-dave-j0p9h616h)]

What is the update on this fix? It's an exasperating bug on some pretty elemental functionality. Very hard to avoid the problem.

[Nicolas Vanhoren (OpenERP) (niv-openerp)]

Despite the fact it could work in some cases, I asked Xavier that did that previous fix and he said he removed it for a good reason and we should not re-introduce it. So we'll find another solution.

[Csaba TOTH (tsabi)]

I tried to revert this fix from my private branch, and immediately some of my wizards started to not work. So i needed to re merge this patch!
So i vote an approve!

review: Approve

Unmerged revisions

3937. By Darshan Kalola(OpenERP) on 2013-05-28

Journal entry: Cannot read property 'id' of null

=== modified file 'addons/web/static/lib/py.js/lib/py.js'
--- addons/web/static/lib/py.js/lib/py.js	2013-05-17 16:22:15 +0000
+++ addons/web/static/lib/py.js/lib/py.js	2013-05-28 06:40:34 +0000
@@ -764,7 +764,14 @@
 
         // Conversion
         toJSON: function () {
-            throw new Error(this.constructor.name + ' can not be converted to JSON');
+            var out = {};
+            for(var k in this) {
+                if (this.hasOwnProperty(k) && !/^__/.test(k)) {
+                    var val = this[k];
+                    out[k] = val.toJSON ? val.toJSON() : val;
+                }
+            }
+            return out;
         }
     });
     var NoneType = py.type('NoneType', null, {