Merge lp:~openerp-dev/openerp-web/7.0-bug-1179505-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Christophe Matthieu (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1179505-bth
Merge into: lp:openerp-web/7.0
Diff against target: 40 lines (+7/-1)
3 files modified
addons/web/static/src/css/base.css (+3/-0)
addons/web/static/src/css/base.sass (+2/-1)
addons/web/static/src/xml/base.xml (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1179505-bth
Reviewer Review Type Date Requested Status
Christophe Matthieu (OpenERP) (community) Disapprove
Review via email: mp+163844@code.launchpad.net

Description of the change

Hello,

    Fixed issue of translation button or icon not displayed with html widget.

Thanks.

To post a comment you must log in.
Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Hi,
Wrong fix, the rendering is ugly. It must be the icon in the toolbar.
I fixed this.
Thanks.

review: Disapprove

Unmerged revisions

3921. By Bhumi Thakkar (Open ERP)

[FIX] Translator button/icon in html widget.--fixes:lp1179505

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2013-04-04 10:23:06 +0000
3+++ addons/web/static/src/css/base.css 2013-05-15 05:43:19 +0000
4@@ -2427,6 +2427,9 @@
5 margin: 3px 0 0 -21px;
6 vertical-align: top;
7 }
8+.openerp .oe_form .oe_form_field_html img.oe_input_icon {
9+ float: right;
10+}
11 .openerp .oe_form .oe_input_icon_disabled {
12 position: absolute;
13 cursor: default;
14
15=== modified file 'addons/web/static/src/css/base.sass'
16--- addons/web/static/src/css/base.sass 2013-04-04 10:23:06 +0000
17+++ addons/web/static/src/css/base.sass 2013-05-15 05:43:19 +0000
18@@ -1947,7 +1947,8 @@
19 margin-top: 32px
20 margin-bottom: 32px
21 text-align: justify
22-
23+ .oe_form_field_html img.oe_input_icon
24+ float: right
25 .oe_form_editable
26 .oe_form
27 .oe_form_field_integer input
28
29=== modified file 'addons/web/static/src/xml/base.xml'
30--- addons/web/static/src/xml/base.xml 2013-04-02 14:40:39 +0000
31+++ addons/web/static/src/xml/base.xml 2013-05-15 05:43:19 +0000
32@@ -1074,6 +1074,8 @@
33 <t t-if="! widget.get('effective_readonly')">
34 <textarea/>
35 </t>
36+ <img class="oe_field_translate oe_input_icon" t-if="widget.field.translate and !widget.get('effective_readonly')"
37+ t-att-src='_s + "/web/static/src/img/icons/terp-translate.png"' width="16" height="16" border="0"/>
38 </div>
39 </t>
40 <t t-name="web.datepicker">