Merge lp:~openerp-dev/openerp-web/7.0-bug-1154057-priyank into lp:openerp-web/7.0

Proposed by Priyank Pandya(OpenERP Trainee)
Status: Rejected
Rejected by: Christophe Matthieu (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1154057-priyank
Merge into: lp:openerp-web/7.0
Diff against target: 31 lines (+7/-0)
1 file modified
addons/web/static/src/js/view_form.js (+7/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1154057-priyank
Reviewer Review Type Date Requested Status
Christophe Matthieu (OpenERP) (community) Disapprove
Review via email: mp+157340@code.launchpad.net

Description of the change

Hello,
    I have fix problem of duplicate tag when press tab key two time.

To post a comment you must log in.
Revision history for this message
Priyank Pandya(OpenERP Trainee) (priyank.pandya-openerp) wrote :

Hello,

It has been fixed into https://code.launchpad.net/~openerp-dev/openerp-web/7.0-bug-1154057-priyank with following

Revision ID: <email address hidden>
Revision No: 3885

Thank you,
Priyank Pandya

Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Hi,
It's a wrong fix. To fix, just clear the list of proposals after a choice clicked.
I fixed this issue in 7.0.
Thanks

review: Disapprove

Unmerged revisions

3885. By Priyank Pandya(OpenERP Trainee)

[FIX] Partners: Duplicate tag with Tab-key

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2013-04-04 10:14:59 +0000
3+++ addons/web/static/src/js/view_form.js 2013-04-05 12:08:56 +0000
4@@ -4084,6 +4084,7 @@
5 return;
6 var self = this;
7 var ignore_blur = false;
8+ var is_new_created = false;
9 self.$text = this.$("textarea");
10 self.$text.textext({
11 plugins : 'tags arrow autocomplete',
12@@ -4096,13 +4097,19 @@
13 ext: {
14 autocomplete: {
15 selectFromDropdown: function() {
16+ if(is_new_created){
17+ is_new_created = false;
18+ return;
19+ }
20 $(this).trigger('hideDropdown');
21 var index = Number(this.selectedSuggestionElement().children().children().data('index'));
22 var data = self.search_result[index];
23 if (data.id) {
24 self.add_id(data.id);
25+ is_new_created = false;
26 } else {
27 ignore_blur = true;
28+ is_new_created = true;
29 data.action();
30 }
31 },