Merge lp:~openerp-dev/openerp-web/7.0-bug-1125218-dharmang into lp:openerp-web/7.0

Proposed by Dharmang Soni (OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1125218-dharmang
Merge into: lp:openerp-web/7.0
Diff against target: 102 lines (+13/-10)
2 files modified
addons/web/static/src/css/base.css (+9/-7)
addons/web/static/src/css/base.sass (+4/-3)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1125218-dharmang
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+157318@code.launchpad.net

Description of the change

Hello,

I have fixed the search box overlap problem with other elements when many filters are added.

Thank You,
Dharmang Soni

To post a comment you must log in.

Unmerged revisions

3885. By Dharmang Soni (OpenERP)

[FIX] Search box doesn't expand to wrap heavy filters, causing the filter to overlap with other elements

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2013-04-04 10:23:06 +0000
3+++ addons/web/static/src/css/base.css 2013-04-05 09:58:34 +0000
4@@ -30,7 +30,7 @@
5 text-shadow: 0 1px 1px rgba(255, 255, 255, 0.5);
6 /* http://www.quirksmode.org/dom/inputfile.html
7 * http://stackoverflow.com/questions/2855589/replace-input-type-file-by-an-image
8- */
9+ */ */
10 }
11 .openerp.openerp_webclient_container {
12 height: 100%;
13@@ -1269,7 +1269,7 @@
14 color: white;
15 padding: 2px 4px;
16 margin: 1px 6px 0 0;
17- border: 1px solid lightgrey;
18+ border: 1px solid lightGray;
19 text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
20 -moz-border-radius: 4px;
21 -webkit-border-radius: 4px;
22@@ -1301,7 +1301,7 @@
23 transform: scale(1.1);
24 }
25 .openerp .oe_secondary_submenu .oe_active {
26- border-top: 1px solid lightgrey;
27+ border-top: 1px solid lightGray;
28 border-bottom: 1px solid #dedede;
29 text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
30 -moz-box-shadow: inset 0 1px 3px rgba(0, 0, 0, 0.2), inset 0 -1px 3px rgba(40, 40, 40, 0.2);
31@@ -1669,14 +1669,14 @@
32 top: 0;
33 right: 18px;
34 width: 15px;
35- height: 100%;
36- background: url(../img/search_reset.gif) center center no-repeat;
37+ height: 20px;
38+ background: url(../img/search_reset.gif) center 7px no-repeat;
39 }
40 .openerp .oe_searchview .oe_searchview_unfold_drawer {
41 position: absolute;
42 top: 0;
43 right: 0;
44- height: 100%;
45+ height: 20px;
46 padding: 0 7px 0 4px;
47 color: #cccccc;
48 cursor: pointer;
49@@ -1752,6 +1752,7 @@
50 .openerp .oe_searchview .oe_searchview_facets .oe_searchview_facet {
51 position: relative;
52 cursor: pointer;
53+ height: auto;
54 padding: 0;
55 -webkit-font-smoothing: auto;
56 }
57@@ -2284,7 +2285,7 @@
58 }
59 .openerp .oe_form .oe_form_label_help[for] span, .openerp .oe_form .oe_form_label[for] span {
60 font-size: 80%;
61- color: darkgreen;
62+ color: darkGreen;
63 vertical-align: top;
64 position: relative;
65 top: -4px;
66@@ -3362,6 +3363,7 @@
67 overflow: hidden !important;
68 }
69 }
70+
71 .blockUI.blockOverlay {
72 background-color: black;
73 opacity: 0.6;
74
75=== modified file 'addons/web/static/src/css/base.sass'
76--- addons/web/static/src/css/base.sass 2013-04-04 10:23:06 +0000
77+++ addons/web/static/src/css/base.sass 2013-04-05 09:58:34 +0000
78@@ -1335,13 +1335,13 @@
79 top: 0
80 right: 18px
81 width: 15px
82- height: 100%
83- background: url(../img/search_reset.gif) center center no-repeat
84+ height: 20px
85+ background: url(../img/search_reset.gif) center 7px no-repeat
86 .oe_searchview_unfold_drawer
87 position: absolute
88 top: 0
89 right: 0
90- height: 100%
91+ height: 20px
92 padding: 0 7px 0 4px
93 color: #ccc
94 cursor: pointer
95@@ -1395,6 +1395,7 @@
96 .oe_searchview_facet
97 position: relative
98 cursor: pointer
99+ height: auto
100 padding: 0
101 -webkit-font-smoothing: auto
102 // spacing for opera, FF