Merge lp:~openerp-dev/openerp-web/7.0-bug-1098829-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1098829-bth
Merge into: lp:openerp-web/7.0
Diff against target: 71 lines (+5/-6)
3 files modified
addons/web/static/src/css/base.css (+2/-3)
addons/web/static/src/css/base.sass (+2/-3)
addons/web/static/src/js/chrome.js (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1098829-bth
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Needs Fixing
Review via email: mp+143296@code.launchpad.net

Description of the change

Hello,

  Fixed issue of layout : for short user names the pull down menu causes horizontal scrolling and shows cut off text.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* Why is right: −0.5px?
* Breaks "More" submenu when many modules installed, not correctly positioned anymore
* Why javascript code?

review: Needs Fixing

Unmerged revisions

3702. By Bhumi Thakkar (Open ERP)

[FIX] Layout issue - short user names - cut off text.--fixes:lp1098829

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/css/base.css'
2--- addons/web/static/src/css/base.css 2013-01-09 13:18:48 +0000
3+++ addons/web/static/src/css/base.css 2013-01-15 12:50:32 +0000
4@@ -669,7 +669,6 @@
5 display: none;
6 position: absolute;
7 top: 26px;
8- left: 0;
9 z-index: 3;
10 margin: 0;
11 padding: 0;
12@@ -710,7 +709,7 @@
13 display: block;
14 color: #4c4c4c;
15 text-decoration: none;
16- width: 200px;
17+ width: auto;
18 text-overflow: ellipsis;
19 overflow: hidden;
20 }
21@@ -1174,7 +1173,7 @@
22 float: left;
23 }
24 .openerp .oe_user_menu .oe_dropdown_menu {
25- right: -1px;
26+ right: -0.5px;
27 }
28 .openerp .oe_systray > div {
29 float: left;
30
31=== modified file 'addons/web/static/src/css/base.sass'
32--- addons/web/static/src/css/base.sass 2013-01-09 13:18:48 +0000
33+++ addons/web/static/src/css/base.sass 2013-01-15 12:50:32 +0000
34@@ -578,7 +578,6 @@
35 display: none
36 position: absolute
37 top: 26px
38- left: 0
39 z-index: 3
40 margin: 0
41 padding: 0
42@@ -604,7 +603,7 @@
43 display: block
44 color: #4c4c4c
45 text-decoration: none
46- width: 200px
47+ width: auto
48 text-overflow: ellipsis
49 overflow: hidden
50 &:hover
51@@ -949,7 +948,7 @@
52 list-style-type: none
53 float: left
54 .oe_dropdown_menu
55- right: -1px
56+ right: -0.5px
57
58 .oe_systray > div
59 float: left
60
61=== modified file 'addons/web/static/src/js/chrome.js'
62--- addons/web/static/src/js/chrome.js 2013-01-08 16:41:04 +0000
63+++ addons/web/static/src/js/chrome.js 2013-01-15 12:50:32 +0000
64@@ -1111,6 +1111,7 @@
65 var x = doc_width - offset.left - menu_width - 2;
66 if (x < 0) {
67 $menu.offset({ left: offset.left + x }).width(menu_width);
68+ $menu.css({'left' : ''});
69 }
70 }
71 }, 0);