Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-dev/openerp-web/7.0-bug-1098230-bth into lp:openerp-web/7.0

  1. 7.0-bug-1098230-bth
  2. Merge into 7.0
Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1098230-bth
Merge into: lp:openerp-web/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/xml/base.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1098230-bth
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+142863@code.launchpad.net

Description of the change

Hello,

  Fixed issue of Arrow of dropdown box should not be drag n drop.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Not fond of adding events (DOM handlers) directly in DOM, this should be in the widget.

review: Disapprove

Unmerged revisions

3698. By Bhumi Thakkar (Open ERP)

[FIX] Arrows from dropdowns shouldn't be drag and droppable.--fixes:lp1098230

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/xml/base.xml'
2--- addons/web/static/src/xml/base.xml 2013-01-02 12:53:44 +0000
3+++ addons/web/static/src/xml/base.xml 2013-01-11 10:52:23 +0000
4@@ -1104,7 +1104,7 @@
5 t-att-placeholder="widget.node.attrs.placeholder"
6 />
7 <span class="oe_m2o_drop_down_button">
8- <img t-att-src='_s + "/web/static/src/img/down-arrow.png"'/>
9+ <img t-att-src='_s + "/web/static/src/img/down-arrow.png"' onmousedown="return false;"/>
10 </span>
11 </div>
12 </t>