Merge lp:~openerp-dev/openerp-web/7.0-bug-1095919-psa into lp:openerp-web/7.0

Proposed by Paramjit Singh Sahota(OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1095919-psa
Merge into: lp:openerp-web/7.0
Diff against target: 49 lines (+16/-4)
2 files modified
addons/web/controllers/main.py (+2/-2)
addons/web/static/src/js/coresetup.js (+14/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1095919-psa
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Needs Information
Review via email: mp+142092@code.launchpad.net

Description of the change

Hello,

Fixed the issue,
>[7.0]Modules:Apps and Modules:Updates emit error, "TypeError: ClientWidget is null"

Thankz YoU.
 -PSA.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

What is the actual bug, what is the problem, and why are you essentially reverting <email address hidden> ?

review: Needs Information
Revision history for this message
Paramjit Singh Sahota(OpenERP) (psa-openerp) wrote :

> What is the actual bug, what is the problem, and why are you essentially
> reverting <email address hidden> ?

Hello,
When I fixed this bug at that time this error exists when we click on the Apps
and at that time the menu where like this

> Installed Modules
> Apps
> Updates

And when we click on APPS it is showing the error msg as below:

>>>> Uncaught TypeError: Cannot read property 'lang' of undefined

Bcz at that time the APPS button is showing the APPS from the https://apps.openerp.com
but now i think that this feature has been removed so itz not showing that error.

Unmerged revisions

3685. By Paramjit Singh Sahota(OpenERP)

[IMP]Improved code.

3684. By Paramjit Singh Sahota(OpenERP)

[MERGE] Merged lp:openerp-web/7.0

3683. By Paramjit Singh Sahota(OpenERP)

[FIX][7.0]Modules:Apps and Modules:Updates emit error, 'TypeError: ClientWidget is null'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/controllers/main.py'
2--- addons/web/controllers/main.py 2012-12-26 18:18:33 +0000
3+++ addons/web/controllers/main.py 2013-01-07 11:06:22 +0000
4@@ -797,9 +797,9 @@
5 return {
6 "session_id": req.session_id,
7 "uid": req.session._uid,
8- "user_context": req.session.get_context() if req.session._uid else {},
9+ "context": req.session.get_context() if req.session._uid else {},
10 "db": req.session._db,
11- "username": req.session._login,
12+ "login": req.session._login,
13 }
14
15 @openerpweb.jsonrequest
16
17=== modified file 'addons/web/static/src/js/coresetup.js'
18--- addons/web/static/src/js/coresetup.js 2012-12-27 07:44:38 +0000
19+++ addons/web/static/src/js/coresetup.js 2013-01-07 11:06:22 +0000
20@@ -85,7 +85,13 @@
21 // If immediately follows a login (triggered by trying to restore
22 // an invalid session or no session at all), refresh session data
23 // (should not change, but just in case...)
24- _.extend(self, result);
25+ _.extend(self, {
26+ session_id: result.session_id,
27+ db: result.db,
28+ username: result.login,
29+ uid: result.uid,
30+ user_context: result.context
31+ });
32 });
33 },
34 session_is_valid: function() {
35@@ -102,7 +108,13 @@
36 if (!result.uid) {
37 return $.Deferred().reject();
38 }
39- _.extend(self, result);
40+ _.extend(self, {
41+ session_id: result.session_id,
42+ db: result.db,
43+ username: result.login,
44+ uid: result.uid,
45+ user_context: result.context
46+ });
47 if (!_volatile) {
48 self.set_cookie('session_id', self.session_id);
49 }