Merge lp:~openerp-dev/openerp-web/7.0-bug-1095283-bth into lp:openerp-web/7.0

[Bhumi Thakkar (Open ERP)]

Hello,

   Close searchview when click on Done button in datepicker in advance search.

To Reproduce:
1. open the search bar menu
2. click on "advanced search"
3. select date
4. click on the calendar icon
5. click on done
=> the whole menu disappears. it should not.

Thanks.

[Fabien Meghazi (OpenERP) (fme)]

Please, merge your jquery selectors when possible :

if ($(ev.target).parents('.oe_searchview').length === 0 && $(ev.target).parents('div#ui-datepicker-div').length === 0) { ...

could be

if (!$(ev.target).parents('.oe_searchview, div#ui-datepicker-div').length) { ...

review: Needs Fixing

[lp:~openerp-dev/openerp-web/7.0-bug-1095283-bth]

3710. By Vidhin Mehta (OpenERP) on 2013-02-21

[MERGE]7.0

3711. By Vidhin Mehta (OpenERP) on 2013-02-21

[FIX]check on direct jquery datetime picker.

[Vidhin Mehta (OpenERP) (vme-openerp)]

In above solution if we click on "Now" button or near about "Now" button,then also same issue observed.
Directly check datetimewidget's dom *is visible or not* from that decide searchview's should remove 'oe_searchview_open_drawer' or not.

review: Needs Resubmitting

[Xavier (Open ERP) (xmo-deactivatedaccount)]

This is not the correct way to fix it: it puts direct knowledge that a sub-widget uses a jquery-ui datetime picker in the search view core (bad) *and* means other views which find themselves in the same situation will have to reimplement the exclusion.

A better fix is to fix the datetime widget or jquery-ui widget.

review: Disapprove

Unmerged revisions

3711. By Vidhin Mehta (OpenERP) on 2013-02-21

[FIX]check on direct jquery datetime picker.

3710. By Vidhin Mehta (OpenERP) on 2013-02-21

[MERGE]7.0

3709. By Bhumi Thakkar (Open ERP) on 2013-01-22

[FIX] Click on done button in datepicker close only datepicker not searchview.--fixes:lp1095283

=== modified file 'addons/web/static/src/js/search.js'
--- addons/web/static/src/js/search.js	2013-02-20 16:33:06 +0000
+++ addons/web/static/src/js/search.js	2013-02-21 13:59:22 +0000
@@ -396,7 +396,7 @@
         }
 
         instance.web.bus.on('click', this, function(ev) {
-            if ($(ev.target).parents('.oe_searchview').length === 0) {
+            if ($(ev.target).parents('.oe_searchview').length === 0 && !$('div#ui-datepicker-div').is(":visible")) {
                 self.$el.removeClass('oe_searchview_open_drawer');
             }
         });