Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-dev/openerp-web/7.0-bug-1095246-bth into lp:openerp-web/7.0

  1. 7.0-bug-1095246-bth
  2. Merge into 7.0
Proposed by Bhumi Thakkar (Open ERP)
Status: Merged
Merged at revision: 3758
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1095246-bth
Merge into: lp:openerp-web/7.0
Diff against target: 25 lines (+2/-2)
2 files modified
addons/web_calendar/static/src/css/web_calendar.css (+1/-1)
addons/web_calendar/static/src/css/web_calendar.sass (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1095246-bth
Reviewer Review Type Date Requested Status
Bhumi Thakkar (Open ERP) (community) Needs Resubmitting
Xavier (Open ERP) (community) Needs Information
Review via email: mp+144284@code.launchpad.net

Description of the change

Hello,

  In calendar view, [calendar/css] Calendar days bar visible under the search menu.
Fixed this issue by set z-index.

Thanks

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* Why are you using javascript to set z-index?
* Why $(ul[0])? (especially when ul probably already a jquery object)
* Why not fix calendar so it doesn't go through search view?

review: Needs Information
lp:~openerp-dev/openerp-web/7.0-bug-1095246-bth updated
3710. By Bhumi Thakkar (Open ERP)

[FIX] Fixed calendar instead of ul of searchvox.

Revision history for this message
Bhumi Thakkar (Open ERP) (bth-openerp) wrote :

> * Why are you using javascript to set z-index?
> * Why $(ul[0])? (especially when ul probably already a jquery object)
> * Why not fix calendar so it doesn't go through search view?

Fixed calendar instead of ul in searchbox.

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_calendar/static/src/css/web_calendar.css'
2--- addons/web_calendar/static/src/css/web_calendar.css 2012-12-17 11:13:40 +0000
3+++ addons/web_calendar/static/src/css/web_calendar.css 2013-01-23 10:07:17 +0000
4@@ -18,7 +18,7 @@
5 .openerp .oe_calendar .dhx_cal_select_menu .dhx_menu_icon.icon_edit {
6 display: none;
7 }
8-.openerp .oe_calendar .dhx_cal_navline {
9+.openerp .oe_calendar .dhx_cal_navline, .openerp .oe_calendar .dhx_cal_header {
10 z-index: auto;
11 }
12 .openerp .oe_calendar.oe_cal_month .dhx_cal_data table tr td:last-child div.dhx_month_body {
13
14=== modified file 'addons/web_calendar/static/src/css/web_calendar.sass'
15--- addons/web_calendar/static/src/css/web_calendar.sass 2012-12-17 11:13:40 +0000
16+++ addons/web_calendar/static/src/css/web_calendar.sass 2013-01-23 10:07:17 +0000
17@@ -20,7 +20,7 @@
18 // Dhtmlx Scheduler css overrides
19 .dhx_cal_select_menu .dhx_menu_icon.icon_edit
20 display: none
21- .dhx_cal_navline
22+ .dhx_cal_navline, .dhx_cal_header
23 // dhtmlx sets the index to 3 (in glossy theme)
24 // I didn't found the reason yet but it overlaps the
25 // dropdown menus and I want to avoid a z-index war.